Skip to content

target_type is no more #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nrnhines merged 2 commits into from
Aug 19, 2025
Merged

target_type is no more #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddfa9e1
target_type is no more
cattabiani Jul 24, 2025
6649eae
fix write
cattabiani Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions commonutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def setup_nrnbbcore_register_mapping(rings):
return recordlist

def write_report_config(output_file, report_name, target_name, report_type, report_variable,
unit, report_format, target_type, dt, start_time, end_time, gids,
unit, report_format, sections, compartments, dt, start_time, end_time, gids,
buffer_size=8, scaling: Literal["none", "area"] = "area"):
"""
Writes the configuration for a report to a file. Check the docs here:
Expand All @@ -182,14 +182,15 @@ def write_report_config(output_file, report_name, target_name, report_type, repo
with report_conf.open("wb") as fp:
# Write the formatted string to the file
fp.write(b"1\n")
fp.write(("%s %s %s %s %s %s %d %lf %lf %lf %d %d %s\n" % (
fp.write(("%s %s %s %s %s %s %s %s %lf %lf %lf %d %d %s\n" % (
report_name,
target_name,
report_type,
report_variable,
unit,
report_format,
target_type,
sections,
compartments,
dt,
start_time,
end_time,
Expand Down
2 changes: 1 addition & 1 deletion ringtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ def create_rings():
sim_conf_file = "sim.conf"
if settings.rank == 0:
write_report_config(report_conf_file, "soma.h5", "Mosaic", "compartment", "v",
"mV", "SONATA", 2, 1, 0, tstop, list(range(ncell)))
"mV", "SONATA", "soma", "center", 1, 0, tstop, list(range(ncell)))
write_spike_config(report_conf_file, "spikes.h5", ["default"], [0])
write_sim_config(sim_conf_file, "corenrn_data", report_conf_file, tstop)
coreneuron.sim_config=sim_conf_file
Expand Down