fix(memcache): restrict Redis evalSha fallback to NOSCRIPT#62064
Open
joshtrichards wants to merge 2 commits into
Open
fix(memcache): restrict Redis evalSha fallback to NOSCRIPT#62064joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
enhancement
2. developing
joshtrichards
requested review from
ArtificialOwl,
icewind1991,
leftybournes and
provokateurin
and removed request for
a team
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adjust
OC\Memcache\Redis::evalLua()to only fall back fromEVALSHAtoEVALwhen Redis reportsNOSCRIPT.The current implementation retries with the full Lua script whenever
evalSha()returnsfalse. This makes the fallback broader than necessary and can treat unrelated Redis failures the same as a missing cached script.Restricting the fallback to
NOSCRIPTkeeps the existing behavior for missing script SHAs while allowing other failures to surface normally.Checklist
3. to review, feature component)stable32)AI (if applicable)