Skip to content

fix(memcache): restrict Redis evalSha fallback to NOSCRIPT #62064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshtrichards wants to merge 2 commits into
base: master
Choose a base branch
from
+23 −4
Open

fix(memcache): restrict Redis evalSha fallback to NOSCRIPT #62064

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bb2ae0
fix(memcache): only fall back to EVAL on Redis NOSCRIPT errors
joshtrichards Jul 13, 2026
02f0ab1
chore(memcache): handle wrong type error in evalLua
joshtrichards Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions lib/private/Memcache/Redis.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ class Redis extends Cache implements IMemcacheTTL {

private const MAX_TTL = 30 * 24 * 60 * 60; // 1 month

private const NO_SCRIPT_ERROR_MESSAGE_PREFIX = 'NOSCRIPT';

private \Redis|\RedisCluster|null $cache = null;

public function __construct($prefix = '', string $logFile = '') {
Expand Down Expand Up @@ -218,12 +220,29 @@ protected function evalLua(string $scriptName, array $keys, array $args) {
$args = array_merge($keys, $args);
$script = self::LUA_SCRIPTS[$scriptName];

$result = $this->getCache()->evalSha($script[1], $args, count($keys));
if ($result === false) {
$result = $this->getCache()->eval($script[0], $args, count($keys));
$cache = $this->getCache();
$cache->clearLastError();

$result = $cache->evalSha($script[1], $args, count($keys));
if ($result !== false) {
return $result;
}

$error = $cache->getLastError();
if ($error !== null && str_starts_with($error, self::NO_SCRIPT_ERROR_MESSAGE_PREFIX)) {
$cache->clearLastError();
return $cache->eval($script[0], $args, count($keys));
}

if ($error !== null && str_starts_with($error, 'WRONGTYPE')) {
return false;
}

if ($error !== null) {
throw new \RuntimeException('Redis EVALSHA failed: ' . $error);
}

return $result;
return false;
}

protected static function encodeValue(mixed $value): string {
Expand Down
Loading