Skip to content

fix(ui): preview mode show the pr number#2018

Open
btea wants to merge 2 commits intonpmx-dev:mainfrom
btea:fix/mobile-show-pr-number
Open

fix(ui): preview mode show the pr number#2018
btea wants to merge 2 commits intonpmx-dev:mainfrom
btea:fix/mobile-show-pr-number

Conversation

@btea
Copy link
Contributor

@btea btea commented Mar 10, 2026

🔗 Linked issue

#1729

🧭 Context

#1729 Mobile devices are not handled.

📚 Description

@vercel
Copy link

vercel bot commented Mar 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 10, 2026 7:02am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 10, 2026 7:02am
npmx-lunaria Ignored Ignored Mar 10, 2026 7:02am

Request Review

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 71472d7d-87d8-4f3c-b89a-c7a89fa56ee4

📥 Commits

Reviewing files that changed from the base of the PR and between ffa05b4 and 4715ebc.

📒 Files selected for processing (4)
  • app/components/AppHeader.vue
  • i18n/locales/en.json
  • i18n/locales/zh-CN.json
  • i18n/schema.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/components/AppHeader.vue

📝 Walkthrough

Walkthrough

Adds a mobile-only GitHub PR badge/link to AppHeader.vue that appears when prNumber is defined and the search is not expanded; it links to the GitHub PR URL and displays "PR #", inserted directly after the AppMark logo in the mobile header. Updates the desktop PR link aria-label to use the new i18n key header.pr with prNumber. Introduces the header.pr translation key in i18n/locales/en.json and i18n/locales/zh-CN.json, and registers header.pr in i18n/schema.json.

Possibly related PRs

Suggested reviewers

  • danielroe
  • serhalp
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description references issue #1729 about mobile device handling, which aligns with the changeset adding a mobile-only PR badge in the header.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2637e916-c5c3-4b24-ad6c-535dcfbf0a80

📥 Commits

Reviewing files that changed from the base of the PR and between 99c9533 and ffa05b4.

📒 Files selected for processing (1)
  • app/components/AppHeader.vue

@github-actions
Copy link

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/en.json Source changed, localizations will be marked as outdated.
i18n/locales/zh-CN.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant