Skip to content

fix(ui): preview mode show the pr number #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
btea wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −3
Open

fix(ui): preview mode show the pr number #2018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffa05b4
fix(ui): preview mode show the pr number
btea Mar 10, 2026
4715ebc
feat: apply review
btea Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion app/components/AppHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,16 @@ onKeyStroke(
>
<AppMark class="w-6 h-auto" />
</NuxtLink>
<NuxtLink
v-if="!isSearchExpanded && prNumber"
:to="`https://github.com/npmx-dev/npmx.dev/pull/${prNumber}`"
:aria-label="$t('header.pr', { prNumber })"
class="sm:hidden"
>
<span class="text-xs px-1.5 py-0.5 rounded badge-green font-sans font-medium ms-2">
PR #{{ prNumber }}
</span>
</NuxtLink>

<!-- Desktop: Logo (navigates home) -->
<div v-if="showLogo" class="hidden sm:flex flex-shrink-0 items-center">
Expand All @@ -238,7 +248,7 @@ onKeyStroke(
<NuxtLink
v-if="prNumber"
:to="`https://github.com/npmx-dev/npmx.dev/pull/${prNumber}`"
:aria-label="`Open GitHub pull request ${prNumber}`"
:aria-label="$t('header.pr', { prNumber })"
>
<span class="text-xs px-1.5 py-0.5 rounded badge-green font-sans font-medium ms-2">
PR #{{ prNumber }}
Expand Down
3 changes: 2 additions & 1 deletion i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,7 +1033,8 @@
"error": "Failed to load organizations",
"empty": "No organizations found",
"view_all": "View all"
}
},
"pr": "Open GitHub pull request #{prNumber}"
},
"compare": {
"packages": {
Expand Down
3 changes: 2 additions & 1 deletion i18n/locales/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1021,7 +1021,8 @@
"error": "加载组织失败",
"empty": "未找到组织",
"view_all": "查看全部"
}
},
"pr": "在 GitHub 上打开 PR #{prNumber}"
},
"compare": {
"packages": {
Expand Down
3 changes: 3 additions & 0 deletions i18n/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3105,6 +3105,9 @@
}
},
"additionalProperties": false
},
"pr": {
"type": "string"
}
},
"additionalProperties": false
Expand Down
Loading