Add Playwright Chromium path verification tooling by Copilot · Pull Request #1795 · openo-beta/Open-O

Copilot · 2026-01-18T06:07:10Z

Reviewer questioned whether .mcp.json Chromium path aligned with Playwright 1.56.0. Investigation confirmed current path is correct (revision 1194, not 1200+), but tooling was needed to prevent future misalignment.

Added verification infrastructure:

.devcontainer/PLAYWRIGHT_SETUP.md: Documents Chromium path structure, version-to-revision mapping, and verification steps
.devcontainer/scripts/verify-playwright-path.sh: Automated checker that validates Dockerfile Playwright version matches .mcp.json executable path
.devcontainer/README.md: Quick reference section for running verification

Verification script capabilities:

# Inside devcontainer
/workspace/.devcontainer/scripts/verify-playwright-path.sh

# Output:
# ✅ Playwright version in Dockerfile: 1.56.0
# ✅ Latest installed Chromium revision: 1194
# ✅ Chromium executable found at: /root/.cache/ms-playwright/chromium-1194/chrome-linux/chrome
# ✅ Configuration is correct!

Script uses numeric sorting for reliable revision comparison and suggests jq-based fixes for path mismatches.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Summary by cubic

Updated the legacy CI test workflow and devcontainer so Playwright tests run reliably in CI and locally. Addresses feedback in #1792 and adds docs and a verify script for the MCP Chromium path.

Bug Fixes
- Standardized Playwright install and runtime dependencies across CI and the devcontainer.
- Simplified the workflow to use consistent test commands and headless execution.

^{Written for commit a817a20. Summary will update on new commits.}

coderabbitai · 2026-01-18T06:07:15Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Co-authored-by: yingbull <8680161+yingbull@users.noreply.github.com>

…ation Co-authored-by: yingbull <8680161+yingbull@users.noreply.github.com>

Copilot · 2026-01-18T06:15:38Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

playwright.dev
- Triggering command: /usr/bin/curl curl -s REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

cubic-dev-ai

No issues found across 3 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

Copilot

Pull request overview

This PR adds verification tooling to ensure the Playwright Chromium executable path in .mcp.json stays aligned with the Playwright version installed in the devcontainer. This addresses feedback from #1792 about potential version misalignment.

Changes:

Added automated verification script that validates Dockerfile Playwright version matches .mcp.json executable path
Created comprehensive documentation for Playwright configuration, version-to-revision mapping, and troubleshooting steps
Added quick reference section to devcontainer README with verification instructions

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File	Description
`.devcontainer/scripts/verify-playwright-path.sh`	Bash script that extracts Playwright version from Dockerfile, finds installed Chromium revision, and validates against `.mcp.json` configuration
`.devcontainer/PLAYWRIGHT_SETUP.md`	Detailed documentation on Chromium path structure, manual verification steps, and version-to-revision mapping table
`.devcontainer/README.md`	Quick reference section for running the verification script with links to detailed documentation

Copilot · 2026-01-18T06:18:47Z

+fi
+
+# Extract the current executable path from .mcp.json
+CURRENT_PATH=$(grep -oP '"--executable-path",\s*"\K[^"]+' "$MCP_JSON" || echo "")


The grep pattern '"--executable-path",\s*"\K[^"]+' uses PCRE syntax with \K (keep) operator and \s* for whitespace. However, this assumes the JSON is formatted with the executable path immediately following the "--executable-path" key. If the JSON structure changes or is reformatted, this could break. Consider using jq to parse the JSON properly instead of grep for more robust extraction.

Suggested change

CURRENT_PATH=$(grep -oP '"--executable-path",\s*"\K[^"]+' "$MCP_JSON" || echo "")

CURRENT_PATH=$(jq -r '.. | arrays? | select(length >= 2 and .[0] == "--executable-path") | .[1]' "$MCP_JSON" 2>/dev/null || echo "")

Copilot · 2026-01-18T06:18:48Z

+   ```bash
+   # For Playwright 1.56.0
+   curl -s https://raw.githubusercontent.com/microsoft/playwright/v1.56.0/packages/playwright-core/browsers.json | grep -A 3 '"name": "chromium"'
+   ```


The curl command example shows checking the browsers.json file from the GitHub repository, but there's no error handling shown. Users following this documentation should be informed that this requires internet connectivity and may fail. Consider adding a note about potential failures or showing the command with error handling.

Copilot · 2026-01-18T06:18:48Z

+echo "📁 Installed Chromium directories:"
+ls -d /root/.cache/ms-playwright/chromium-* 2>/dev/null || echo "  None found"
+
+# Get the latest installed Chromium revision


The numeric sorting command sort -t- -k2 -n is correct for sorting chromium revision numbers. However, consider adding a comment explaining this sorting logic since it's a critical part of finding the latest revision. The -t- sets the delimiter to hyphen, -k2 selects the second field (the revision number), and -n does numeric sorting.

Suggested change

# Get the latest installed Chromium revision

# Get the latest installed Chromium revision

# We sort directories like "chromium-123456" numerically by the revision part:

# -t- : use '-' as the field delimiter (e.g., "chromium-123456" -> fields: chromium | 123456)

# -k2 : sort by the second field (the numeric revision)

# -n : perform numeric sort so higher revisions are ordered last

Copilot · 2026-01-18T06:18:48Z

+| 1.57.0            | 1200              | 143.0.7499.4             |
+


The version mapping table shows Playwright 1.57.0 → Chromium revision 1200, but this should be verified against the actual Playwright release. The documentation encourages users to check browsers.json for verification, which is good. Consider adding a note that this table should be updated when new Playwright versions are installed in the Dockerfile.

Suggested change

| 1.57.0 | 1200 | 143.0.7499.4 |

**Important**: Keep this table in sync with the Playwright version specified in `.devcontainer/development/Dockerfile`. When you bump the Playwright version in the Dockerfile, add or update rows here using the corresponding `browsers.json` from that Playwright release.

Copilot · 2026-01-18T06:18:49Z

@@ -0,0 +1,94 @@
+#!/bin/bash


The script's shebang line is missing a space between #!/bin/bash. While this works in most cases, the canonical form should be #!/bin/bash (with a space).

Suggested change

#!/bin/bash

#! /bin/bash

Copilot · 2026-01-18T06:18:49Z

+fi
+
+# Get Playwright version from Dockerfile
+PLAYWRIGHT_VERSION=$(grep -oP 'playwright@\K[0-9.]+' /workspace/.devcontainer/development/Dockerfile || echo "unknown")


The grep pattern uses -oP (PCRE) but doesn't escape the period in the version pattern. While this works, it would be more precise to use [0-9.]+ or better yet, [0-9]+\.[0-9]+\.[0-9]+ to match semantic versioning format. The current pattern could theoretically match invalid version strings.

Suggested change

PLAYWRIGHT_VERSION=$(grep -oP 'playwright@\K[0-9.]+' /workspace/.devcontainer/development/Dockerfile || echo "unknown")

PLAYWRIGHT_VERSION=$(grep -oP 'playwright@\K[0-9]+\.[0-9]+\.[0-9]+' /workspace/.devcontainer/development/Dockerfile || echo "unknown")

Copilot · 2026-01-18T06:18:49Z

+    echo "   ${EXPECTED_PATH}"
+    echo
+    echo "Or use jq to update it programmatically:"
+    echo "   jq '.mcpServers.playwright.args |= map(if . == \"--executable-path\" then . else if . == \"${CURRENT_PATH}\" then \"${EXPECTED_PATH}\" else . end end)' ${MCP_JSON} > ${MCP_JSON}.tmp && mv ${MCP_JSON}.tmp ${MCP_JSON}"


The jq command suggestion on line 89 has a potential issue - it uses double quotes for the outer string which means the variables ${CURRENT_PATH} and ${EXPECTED_PATH} will be expanded by the shell before being passed to jq, but they're also inside the jq string which could cause issues. The suggestion should use single quotes for the jq expression and construct the replacement properly, or provide a clearer example that avoids nested quote issues.

Suggested change

echo " jq '.mcpServers.playwright.args |= map(if . == \"--executable-path\" then . else if . == \"${CURRENT_PATH}\" then \"${EXPECTED_PATH}\" else . end end)' ${MCP_JSON} > ${MCP_JSON}.tmp && mv ${MCP_JSON}.tmp ${MCP_JSON}"

echo " jq --arg old \"${CURRENT_PATH}\" --arg new \"${EXPECTED_PATH}\" '.mcpServers.playwright.args |= map(if . == \"--executable-path\" then . else if . == \$old then \$new else . end end)' ${MCP_JSON} > ${MCP_JSON}.tmp && mv ${MCP_JSON}.tmp ${MCP_JSON}"

Initial plan

5a68648

Copilot AI assigned Copilot and yingbull Jan 18, 2026

Copilot AI mentioned this pull request Jan 18, 2026

chore: workflow fixes and devcontainer realign for playwright, initia… #1792

Merged

Copilot started work on behalf of yingbull January 18, 2026 06:07 View session

Copilot AI and others added 2 commits January 18, 2026 06:12

docs: add Playwright Chromium path verification tools and documentation

1422fb7

Co-authored-by: yingbull <8680161+yingbull@users.noreply.github.com>

fix: improve verification script with better sorting and JSON manipul…

a817a20

…ation Co-authored-by: yingbull <8680161+yingbull@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Update workflow fixes and devcontainer adjustments for Playwright~~ Add Playwright Chromium path verification tooling Jan 18, 2026

Copilot AI requested a review from yingbull January 18, 2026 06:15

Copilot finished work on behalf of yingbull January 18, 2026 06:15

yingbull marked this pull request as ready for review January 18, 2026 06:15

Copilot AI review requested due to automatic review settings January 18, 2026 06:15

yingbull merged commit 4257d85 into fix/legacy-test-workflow-fix Jan 18, 2026
8 of 10 checks passed

yingbull deleted the copilot/sub-pr-1792-another-one branch January 18, 2026 06:16

Copilot started reviewing on behalf of yingbull January 18, 2026 06:16 View session

cubic-dev-ai Bot reviewed Jan 18, 2026

View reviewed changes

Copilot AI reviewed Jan 18, 2026

View reviewed changes

yingbull mentioned this pull request Jan 20, 2026

feat: Lab Format Generators, Flowsheet Enhancements, Security Fixes, and DevOps Improvements open-osp/Open-O#185

Merged

9 tasks

	CURRENT_PATH=$(grep -oP '"--executable-path",\s*"\K[^"]+' "$MCP_JSON" \|\| echo "")
	CURRENT_PATH=$(jq -r '.. \| arrays? \| select(length >= 2 and .[0] == "--executable-path") \| .[1]' "$MCP_JSON" 2>/dev/null \|\| echo "")

-# Get the latest installed Chromium revision
+# Get the latest installed Chromium revision
+# We sort directories like "chromium-123456" numerically by the revision part:
+#   -t- : use '-' as the field delimiter (e.g., "chromium-123456" -> fields: chromium | 123456)
+#   -k2 : sort by the second field (the numeric revision)
+#   -n  : perform numeric sort so higher revisions are ordered last

	\| 1.57.0 \| 1200 \| 143.0.7499.4 \|

	Important: Keep this table in sync with the Playwright version specified in `.devcontainer/development/Dockerfile`. When you bump the Playwright version in the Dockerfile, add or update rows here using the corresponding `browsers.json` from that Playwright release.

	PLAYWRIGHT_VERSION=$(grep -oP 'playwright@\K[0-9.]+' /workspace/.devcontainer/development/Dockerfile \|\| echo "unknown")
	PLAYWRIGHT_VERSION=$(grep -oP 'playwright@\K[0-9]+\.[0-9]+\.[0-9]+' /workspace/.devcontainer/development/Dockerfile \|\| echo "unknown")

	echo " jq '.mcpServers.playwright.args \|= map(if . == \"--executable-path\" then . else if . == \"${CURRENT_PATH}\" then \"${EXPECTED_PATH}\" else . end end)' ${MCP_JSON} > ${MCP_JSON}.tmp && mv ${MCP_JSON}.tmp ${MCP_JSON}"
	echo " jq --arg old \"${CURRENT_PATH}\" --arg new \"${EXPECTED_PATH}\" '.mcpServers.playwright.args \|= map(if . == \"--executable-path\" then . else if . == \$old then \$new else . end end)' ${MCP_JSON} > ${MCP_JSON}.tmp && mv ${MCP_JSON}.tmp ${MCP_JSON}"

Uh oh!

Conversation

Copilot AI commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Uh oh!

coderabbitai Bot commented Jan 18, 2026

Review skipped

Uh oh!

Copilot AI commented Jan 18, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Jan 18, 2026 •

edited

Loading