fix: enable image push on manual workflow_dispatch with force_rebuild#1804
Merged
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
…istry Co-authored-by: yingbull <8680161+yingbull@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix caching approach for container image updates
fix: enable image push on manual workflow_dispatch with force_rebuild
Jan 18, 2026
yingbull
approved these changes
Jan 18, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where manual workflow_dispatch runs would build container images but never push them to GitHub Container Registry (GHCR), even when force_rebuild=true was specified. The fix enables maintainers to manually trigger container rebuilds and have those images published to the registry.
Changes:
- Updated push conditions in all three container build jobs to allow pushing when triggered by workflow_dispatch with force_rebuild=true
- Maintains existing behavior: PR builds don't push, branch commits always push, manual dispatch without force_rebuild doesn't push
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback from #1796: manual
workflow_dispatchruns were building containers but never pushing to GHCR, even withforce_rebuild=true.Changes
Updated push conditions in all three build jobs (
build-tomcat,build-mariadb,build-drugref):Behavior
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Summary by cubic
Clarifies image publishing rules. PR builds don’t push; merges push; maintainers can manually rebuild and publish via workflow_dispatch with force_rebuild=true.
Written for commit 332447e. Summary will update on new commits.