Skip to content

fix: include my.cnf in mariadb-dev container hash calculation#1806

Merged
yingbull merged 3 commits into
feature/cache-build-workflowsfrom
copilot/sub-pr-1796-again
Jan 18, 2026
Merged

fix: include my.cnf in mariadb-dev container hash calculation#1806
yingbull merged 3 commits into
feature/cache-build-workflowsfrom
copilot/sub-pr-1796-again

Conversation

Copilot AI commented Jan 18, 2026

Copy link
Copy Markdown

The MariaDB container freshness check was missing my.cnf from its content hash, causing missed rebuilds when database configuration changed.

Changes:

  • Add .devcontainer/development/config/shared to mariadb-dev extra_context paths
  • Include *.cnf pattern in hash calculation (was only matching *.conf)

The MariaDB Dockerfile copies my.cnf during build:

COPY ./.devcontainer/development/config/shared/my.cnf /etc/mysql/my.cnf

But the hash calculation only scanned .devcontainer/db and database/, missing the config file entirely. Now changes to database tuning parameters, character sets, or other my.cnf settings will correctly trigger container rebuilds.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.


Summary by cubic

Adds container image caching and streamlines CI to shorten builds and reduce registry traffic. Also fixes the my.cnf hash mismatch so image hashes are consistent.

  • New Features

    • Cache container images in CI to reuse builds and avoid redundant pulls.
  • Bug Fixes

    • Fix my.cnf-related hash mismatch to produce deterministic artifacts.

Written for commit 56db4da. Summary will update on new commits.

@coderabbitai

coderabbitai Bot commented Jan 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.


Comment @coderabbitai help to get the list of available commands and usage tips.

Co-authored-by: yingbull <8680161+yingbull@users.noreply.github.com>
Copilot AI changed the title [WIP] Add caching for container images and improve CI workflow fix: include my.cnf in mariadb-dev container hash calculation Jan 18, 2026
Copilot AI requested a review from yingbull January 18, 2026 18:27
@yingbull yingbull marked this pull request as ready for review January 18, 2026 18:34
Copilot AI review requested due to automatic review settings January 18, 2026 18:34

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a bug in the MariaDB container freshness check where changes to the my.cnf database configuration file were not triggering container rebuilds. The fix ensures that modifications to database tuning parameters, character sets, or other MariaDB configuration settings will properly invalidate the container cache.

Changes:

  • Added .devcontainer/development/config/shared to the mariadb-dev container's extra_context paths to include the directory containing my.cnf
  • Added *.cnf file pattern to the hash calculation in both conditional branches (with and without extra_context)
  • Removed quotes around $extra_context variable to enable multiple space-separated paths

Comment thread .github/workflows/container-images.yml Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@yingbull yingbull merged commit 17d4a65 into feature/cache-build-workflows Jan 18, 2026
5 of 7 checks passed
@yingbull yingbull deleted the copilot/sub-pr-1796-again branch January 18, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants