fix: include my.cnf in mariadb-dev container hash calculation#1806
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Comment |
Co-authored-by: yingbull <8680161+yingbull@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug in the MariaDB container freshness check where changes to the my.cnf database configuration file were not triggering container rebuilds. The fix ensures that modifications to database tuning parameters, character sets, or other MariaDB configuration settings will properly invalidate the container cache.
Changes:
- Added
.devcontainer/development/config/sharedto the mariadb-dev container's extra_context paths to include the directory containingmy.cnf - Added
*.cnffile pattern to the hash calculation in both conditional branches (with and without extra_context) - Removed quotes around
$extra_contextvariable to enable multiple space-separated paths
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
The MariaDB container freshness check was missing
my.cnffrom its content hash, causing missed rebuilds when database configuration changed.Changes:
.devcontainer/development/config/sharedto mariadb-dev extra_context paths*.cnfpattern in hash calculation (was only matching*.conf)The MariaDB Dockerfile copies
my.cnfduring build:COPY ./.devcontainer/development/config/shared/my.cnf /etc/mysql/my.cnfBut the hash calculation only scanned
.devcontainer/dbanddatabase/, missing the config file entirely. Now changes to database tuning parameters, character sets, or other my.cnf settings will correctly trigger container rebuilds.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Summary by cubic
Adds container image caching and streamlines CI to shorten builds and reduce registry traffic. Also fixes the my.cnf hash mismatch so image hashes are consistent.
New Features
Bug Fixes
Written for commit 56db4da. Summary will update on new commits.