Skip to content

Fix: typo in Invoice Reports status filter label ("Submmitted" → "Submitted")#2484

Open
LiamStanziani wants to merge 1 commit into
developfrom
bug/typos-in-oscar-gui
Open

Fix: typo in Invoice Reports status filter label ("Submmitted" → "Submitted")#2484
LiamStanziani wants to merge 1 commit into
developfrom
bug/typos-in-oscar-gui

Conversation

@LiamStanziani

@LiamStanziani LiamStanziani commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Corrects a spelling mistake in the Ontario billing Invoice Reports screen, where the
"Submitted OHIP" status-filter radio button was mislabelled "Submmitted OHIP" (double "m").
This is a one-line, display-only text change with no functional impact.

Closes: Typos in OSCAR GUI

Problem

In Admin Panel → Billing → Invoice Reports, the radio button used to filter invoices by
status rendered its label as "Submmitted OHIP" instead of "Submitted OHIP". The misspelling
was visible to every user of the Ontario billing reporting screen.

  • File: src/main/webapp/billing/CA/ON/billingONStatus.jsp
  • Element: statusType radio button, value="B"

Solution

Corrected the label text from Submmitted to Submitted.

                             <label class="radio inline"><input type="radio" name="statusType"
-                                                               value="B" <%=statusType.equals("B")?"checked":""%>>Submmitted
+                                                               value="B" <%=statusType.equals("B")?"checked":""%>>Submitted
                                 OHIP</label>

UI Before:

image

UI After:

Screenshot_20260624_164329

Only the user-visible label text was changed. The radio button's value="B" — the value submitted
to the server and used for filtering — is untouched, so there is no behavioural or data change.

Testing

  • Visual verification: the radio button on the Invoice Reports screen now reads "Submitted OHIP".
  • No logic, request parameters, or stored values were modified.

Summary by Sourcery

Bug Fixes:

  • Fix a typo in the "Submitted OHIP" status filter label in the Ontario billing Invoice Reports screen.

Summary by cubic

Fixed a misspelling in the Ontario billing Invoice Reports status filter: "Submmitted OHIP" is now "Submitted OHIP".
Display-only change; no logic, values, or behavior affected.

Written for commit 80b0442. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • Corrected a typo in the billing status label from “Submmitted” to “Submitted” for clearer, more polished text.

@LiamStanziani LiamStanziani self-assigned this Jun 24, 2026
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The PR updates one billing status radio label in the Ontario JSP from “Submmitted” to “Submitted”. No filtering, retrieval, or other logic changes are included.

Changes

Billing status label correction

Layer / File(s) Summary
Status radio label text
src/main/webapp/billing/CA/ON/billingONStatus.jsp
The statusType radio option with value B renders the corrected label text “Submitted”.

Sequence Diagram(s)

Not applicable.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 I hopped by the billing row,
And fixed one tiny word below.
“Submmitted” took a carrot nap,
Now “Submitted” sits in its cap.
A neat little nibble, all aglow ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the visible change to the Invoice Reports status filter label.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bug/typos-in-oscar-gui

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR fixes a typo in the Ontario billing Invoice Reports JSP by correcting the user-visible label text for the 'Submitted OHIP' status filter radio button, without altering any functional behavior or server-submitted values.

File-Level Changes

Change Details Files
Corrected the displayed label text for the 'Submitted OHIP' status filter radio button.
  • Updated the radio button label text from 'Submmitted' to 'Submitted' while keeping the value="B" and logic unchanged
  • Ensured this is a display-only change with no impact on filtering behavior or submitted parameters
src/main/webapp/billing/CA/ON/billingONStatus.jsp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 80b0442.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a typographical error in billingONStatus.jsp, changing 'Submmitted' to 'Submitted' for the OHIP status label. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@LiamStanziani

Copy link
Copy Markdown
Collaborator Author

@SourceryAI review

@LiamStanziani

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@LiamStanziani LiamStanziani marked this pull request as ready for review June 24, 2026 20:58
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@LiamStanziani LiamStanziani requested a review from D3V41 June 24, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants