Update registry.access.redhat.com/ubi9/go-toolset Docker tag to v1.25.9-1778675823#145
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @red-hat-konflux-kflux-prd-rh02[bot]. Thanks for your PR. I'm waiting for a openshift-hyperfleet member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Dockerfile builder stage base image was changed from the floating tag Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
….9-1778675823 Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
a69477e to
2db4c3d
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Dockerfile`:
- Line 3: You pinned the builder image in the Dockerfile by changing the FROM
line to registry.access.redhat.com/ubi9/go-toolset:1.25.9-1778675823, which
diverges from other hyperfleet services that still use the floating tag
registry.access.redhat.com/ubi9/go-toolset:1.25; to fix, coordinate and
standardize the builder image tag across all hyperfleet repos and architecture
docs (or decide to revert to the floating tag), update the Dockerfile's FROM
reference accordingly (or update other services to the pinned tag), and adjust
any architecture documentation/examples to reflect the agreed-upon tag so build
environments remain consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: e9189d7a-b3e6-46a7-85c3-86a08206fb8e
📒 Files selected for processing (1)
Dockerfile
| ARG BASE_IMAGE=registry.access.redhat.com/ubi9-micro:latest | ||
|
|
||
| FROM registry.access.redhat.com/ubi9/go-toolset:1.25 AS builder | ||
| FROM registry.access.redhat.com/ubi9/go-toolset:1.25.9-1778675823 AS builder |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider coordinating image pin across hyperfleet services.
The linked repository findings show that other hyperfleet services (hyperfleet-sentinel, hyperfleet-adapter) and architecture documentation examples still reference the unpinned registry.access.redhat.com/ubi9/go-toolset:1.25 tag. Pinning this repository's builder image while others remain on the floating tag creates divergence in build environments across the hyperfleet ecosystem.
If pinning builder images is being adopted as a standard practice, consider propagating this change to other services and updating the architecture documentation to maintain consistency.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Dockerfile` at line 3, You pinned the builder image in the Dockerfile by
changing the FROM line to
registry.access.redhat.com/ubi9/go-toolset:1.25.9-1778675823, which diverges
from other hyperfleet services that still use the floating tag
registry.access.redhat.com/ubi9/go-toolset:1.25; to fix, coordinate and
standardize the builder image tag across all hyperfleet repos and architecture
docs (or decide to revert to the floating tag), update the Dockerfile's FROM
reference accordingly (or update other services to the pinned tag), and adjust
any architecture documentation/examples to reflect the agreed-upon tag so build
environments remain consistent.
|
Closing: superseded by renovate.json config in #158 (HYPERFLEET-1095). MintMaker will re-create grouped updates on the next Monday cycle. |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update ( If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
1.25→1.25.9-1778675823Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.