Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ARG BASE_IMAGE=registry.access.redhat.com/ubi9-micro:latest

FROM registry.access.redhat.com/ubi9/go-toolset:1.25 AS builder
FROM registry.access.redhat.com/ubi9/go-toolset:1.25.9-1778675823 AS builder
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | πŸ”΅ Trivial

Consider coordinating image pin across hyperfleet services.

The linked repository findings show that other hyperfleet services (hyperfleet-sentinel, hyperfleet-adapter) and architecture documentation examples still reference the unpinned registry.access.redhat.com/ubi9/go-toolset:1.25 tag. Pinning this repository's builder image while others remain on the floating tag creates divergence in build environments across the hyperfleet ecosystem.

If pinning builder images is being adopted as a standard practice, consider propagating this change to other services and updating the architecture documentation to maintain consistency.

πŸ€– Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Dockerfile` at line 3, You pinned the builder image in the Dockerfile by
changing the FROM line to
registry.access.redhat.com/ubi9/go-toolset:1.25.9-1778675823, which diverges
from other hyperfleet services that still use the floating tag
registry.access.redhat.com/ubi9/go-toolset:1.25; to fix, coordinate and
standardize the builder image tag across all hyperfleet repos and architecture
docs (or decide to revert to the floating tag), update the Dockerfile's FROM
reference accordingly (or update other services to the pinned tag), and adjust
any architecture documentation/examples to reflect the agreed-upon tag so build
environments remain consistent.


ARG GIT_SHA=unknown
ARG GIT_DIRTY=""
Expand Down