Update module cloud.google.com/go/pubsub/v2 to v2.6.0#130
Update module cloud.google.com/go/pubsub/v2 to v2.6.0#130red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
Conversation
Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @red-hat-konflux-kflux-prd-rh02[bot]. Thanks for your PR. I'm waiting for a openshift-hyperfleet member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughWalkthroughThis pull request updates the indirect dependency Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 44: Summary: Dependency version mismatch for
cloud.google.com/go/pubsub/v2 (sentinel uses v2.6.0 while hyperfleet-broker and
hyperfleet-adapter still depend on v2.4.0). Update instructions: Open the go.mod
files in the hyperfleet-broker and hyperfleet-adapter repositories and change
the cloud.google.com/go/pubsub/v2 module version to v2.6.0 to match sentinel,
run `go get cloud.google.com/go/pubsub/v2@v2.6.0` (or `go mod tidy`) in each
repo to update transitive dependencies, run the test suites and any integration
jobs to verify behavior, and then commit and push the synchronized go.mod/go.sum
updates so all three repos reference v2.6.0 consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 2bdd9ccf-bc3c-4644-883f-c5adfda59855
📒 Files selected for processing (1)
go.mod
| cloud.google.com/go/compute/metadata v0.9.0 // indirect | ||
| cloud.google.com/go/iam v1.5.3 // indirect | ||
| cloud.google.com/go/pubsub/v2 v2.4.0 // indirect | ||
| cloud.google.com/go/pubsub/v2 v2.6.0 // indirect |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Coordinate version update across dependent repositories.
The linked repository hyperfleet-broker (which sentinel depends on at line 11) still uses cloud.google.com/go/pubsub/v2 v2.4.0 as a direct dependency. Similarly, hyperfleet-adapter also references v2.4.0. This creates version inconsistency across the HyperFleet project.
While Go's minimal version selection will handle this, it's better to coordinate the upgrade across all repositories that use this module to ensure consistent behavior and testing. Consider updating hyperfleet-broker and hyperfleet-adapter to v2.6.0 as well.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 44, Summary: Dependency version mismatch for
cloud.google.com/go/pubsub/v2 (sentinel uses v2.6.0 while hyperfleet-broker and
hyperfleet-adapter still depend on v2.4.0). Update instructions: Open the go.mod
files in the hyperfleet-broker and hyperfleet-adapter repositories and change
the cloud.google.com/go/pubsub/v2 module version to v2.6.0 to match sentinel,
run `go get cloud.google.com/go/pubsub/v2@v2.6.0` (or `go mod tidy`) in each
repo to update transitive dependencies, run the test suites and any integration
jobs to verify behavior, and then commit and push the synchronized go.mod/go.sum
updates so all three repos reference v2.6.0 consistently.
|
Closing: superseded by renovate.json config in #135 (HYPERFLEET-1095). MintMaker will re-create grouped updates on the next Monday cycle. |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update ( If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
v2.4.0→v2.6.0Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.