Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ require (
cloud.google.com/go/auth/oauth2adapt v0.2.8 // indirect
cloud.google.com/go/compute/metadata v0.9.0 // indirect
cloud.google.com/go/iam v1.5.3 // indirect
cloud.google.com/go/pubsub/v2 v2.4.0 // indirect
cloud.google.com/go/pubsub/v2 v2.6.0 // indirect
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | πŸ”΅ Trivial

Coordinate version update across dependent repositories.

The linked repository hyperfleet-broker (which sentinel depends on at line 11) still uses cloud.google.com/go/pubsub/v2 v2.4.0 as a direct dependency. Similarly, hyperfleet-adapter also references v2.4.0. This creates version inconsistency across the HyperFleet project.

While Go's minimal version selection will handle this, it's better to coordinate the upgrade across all repositories that use this module to ensure consistent behavior and testing. Consider updating hyperfleet-broker and hyperfleet-adapter to v2.6.0 as well.

πŸ€– Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 44, Summary: Dependency version mismatch for
cloud.google.com/go/pubsub/v2 (sentinel uses v2.6.0 while hyperfleet-broker and
hyperfleet-adapter still depend on v2.4.0). Update instructions: Open the go.mod
files in the hyperfleet-broker and hyperfleet-adapter repositories and change
the cloud.google.com/go/pubsub/v2 module version to v2.6.0 to match sentinel,
run `go get cloud.google.com/go/pubsub/v2@v2.6.0` (or `go mod tidy`) in each
repo to update transitive dependencies, run the test suites and any integration
jobs to verify behavior, and then commit and push the synchronized go.mod/go.sum
updates so all three repos reference v2.6.0 consistently.

dario.cat/mergo v1.0.2 // indirect
github.com/Azure/go-ansiterm v0.0.0-20250102033503-faa5f7b0171c // indirect
github.com/Microsoft/go-winio v0.6.2 // indirect
Expand Down