AO3-7353 Fix "Refused Gifts" button failed to show pressed when selected

[runxii]

Pull Request Checklist

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-7353

Purpose

Fixed the bug when the "Refused Gifts" is pressed, but the UI does not show that it is pressed. (On the page "My Dashboard">"Gifts")

Fixed by passing the right condition to span_if_current in app/views/gifts/index.html.erb, which should check if refused is true in the URL.

Testing Instructions

1. Log in
2. Hi, username! > My Dashboard
3. Follow “Gifts” in the sidebar
4. Press "Refused Gifts"
5. Changed the URL to https://localhost:3000/users/testuser/gifts?sorted=DESC&refused=true, the button remains pressed.

References

Switching the params to reproduce the error was mentioned in AO3-7133

Credit

Yang (she/her)

[sarken]

Hi, Yang!

Thank you so much for this pull request. Someone will be along to review it soon.

For now, I've updated the Jira issue status to In Review so no one mistakenly creates a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)."

Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you.

Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above.

[runxii]

@sarken
Hi Sarken,

Thank you so much for your contribution to managing the repository! I'd love to join the Jira team with the following account:

Email: runxii@outlook.com
Name: runxii (Yang)

[sarken]

Your account should hopefully be all set the next time you log in, but Jira's having a major outage on the admin side of things right now, so it's possible the permissions didn't get set up correctly. Feel free to ping me if you run into any issues!

[Bilka2]

Thanks for working on this!

[Bilka2]

It looks like all other code in the controller and view only check whether the parameter is present, not whether it's true, so could you adjust this to only check .present? as well?

[runxii]

Thank you for the review! I changed the code to check .present rather than true. The erb-lint failed because it suggested Rails built-in t helper over ts, but I meant to align with the original code so preferred to change as less as possible. If there's anything else to be changed, I'm glad to work on it.