Skip to content

AO3-7353 Fix "Refused Gifts" button failed to show pressed when selected #5697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
runxii wants to merge 3 commits into
base: master
Choose a base branch
from
+1 −1
Open

AO3-7353 Fix "Refused Gifts" button failed to show pressed when selected #5697

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0379f9
AO3-7353 Fix "Refused Gifts" button failed to show pressed when selected
runxii Apr 3, 2026
f5b9d8c
Merge branch 'master' into AO3-7353_refused_gifts_not_pressed
runxii Apr 11, 2026
bd7eedf
AO3-7353 Fix "Refused Gifts" button, condition exist, not equal to true
runxii Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/gifts/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<%= span_if_current ts("Accepted Gifts"), user_gifts_path(@user), !(params[:refused]) %>
</li>
<li>
<%= span_if_current ts("Refused Gifts"), user_gifts_path(@user, refused: true) %>
<%= span_if_current ts("Refused Gifts"), user_gifts_path(@user, refused: true), params[:refused] %>

Check failure on line 20 in app/views/gifts/index.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[] reported by reviewdog 🐶
I18n/DeprecatedHelper: Prefer Rails built-in `t` helper over `ts` and move the text into the yml file. `ts` is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards

Raw Output:
app/views/gifts/index.html.erb:20:26: I18n/DeprecatedHelper: Prefer Rails built-in `t` helper over `ts` and move the text into the yml file. `ts` is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
</li>
</ul>
<% elsif !@user %>
Expand Down
Loading