AO3-7375 Fix TypeError by adding localStorage feature check for accepted_tos check#5704
Open
mjec wants to merge 1 commit intootwcode:masterfrom
Open
AO3-7375 Fix TypeError by adding localStorage feature check for accepted_tos check#5704mjec wants to merge 1 commit intootwcode:masterfrom
mjec wants to merge 1 commit intootwcode:masterfrom
Conversation
Before this commit if localStroage was not available at all, the check for accept_tos would result in: Uncaught TypeError: can't access property "getItem", localStorage is null This breaks all subsequent JS on the page, including further jquery `$j(document).ready()` callbacks.
Collaborator
|
Thanks for finding this! I've made AO3-7375 and assigned it to you. However, in the future, please wait for someone to verify the problem and create an issue before opening a pull request. (Edited to fix the link.) |
mjec
changed the title
mjec
changed the title
Author
|
Apologies for the nonsense |
Bilka2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7375
Purpose
Check that
localStorageis supported before using it to look for anaccepted_tosentry. This prevents an error likeUncaught TypeError: can't access property "getItem", localStorage is nullwhich breaks subsequent JS on the page, including further jquery$j(document).ready()callbacks.Testing Instructions
In Firefox, set
dom.storage.enabledtofalseinabout:config. Load any page and open the JS console, observe noUncaught TypeError.Compare to the same on
master, which does result in theTypeError.References
Discovered and discussed in #5641, specifically under the last details block in the comment attaching screenshots.
Credit
mjec (they/them)