Skip to content

AO3-7375 Fix TypeError by adding localStorage feature check for accepted_tos check #5704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mjec wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

AO3-7375 Fix TypeError by adding localStorage feature check for accepted_tos check #5704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/layouts/_javascripts.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
cookie need the popup.
We have to use JavaScript to remember their choice or risk issues
when full page caching is enabled. %>
if (localStorage.getItem("accepted_tos") !== "<%= @current_tos_version %>" && Cookies.get("accepted_tos") !== "<%= @current_tos_version %>") {
if ((!isSupported() || localStorage.getItem("accepted_tos") !== "<%= @current_tos_version %>") && Cookies.get("accepted_tos") !== "<%= @current_tos_version %>") {
$j("body").prepend("<%= escape_javascript(render "layouts/tos_prompt") %>");
}
<% end %>
Expand Down
Loading