OptimizeFor toSSE: honor withoutNormals when creating bsOptShape#21
Merged
ousnius merged 2 commits intoousnius:mainfrom Apr 25, 2026
Merged
Conversation
The toSSE branch computed `withoutNormals = true` for ModelSpace shaders but always passed `geomData.Normals` to bsOptShape.Create, so the flag had no effect. Normals ended up persisted on shapes that should not carry them. Matches C++ nifly NifFile.cpp:1565-1569, where the toSSE equivalent sets the `normals` pointer to `nullptr` before calling Create at NifFile.cpp:1652. The toLE branch in the same C# file already had the correct `!withoutNormals ? ... : null` pattern; this brings the toSSE branch in line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toSSE branch of
OptimizeForalways passesgeomData.Normalswhen constructingbsOptShape, even whenwithoutNormalsis true. The toLE branch already uses the correct!withoutNormals ? ... : nullpattern; this brings toSSE in line.C++ reference:
nifly/NifFile.cpp:1565-1569— C++ nullsnormals = nullptrbefore passing it toCreate()whenremoveNormalsis true.Fix: gate the
Normalsargument onwithoutNormals.Maps to issue #15 item A2.