Skip to content

OptimizeFor toSSE: honor withoutNormals when creating bsOptShape #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ousnius merged 2 commits into from
Apr 25, 2026
Merged

OptimizeFor toSSE: honor withoutNormals when creating bsOptShape #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed5029a
OptimizeFor toSSE: honor withoutNormals when creating bsOptShape
MANOLOV02 Apr 25, 2026
bdafad4
Remove nifly comment
ousnius Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion NiflySharp/NifFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1970,7 +1970,8 @@ public NifFileOptimizeResult OptimizeFor(NifFileOptimizeOptions options)
bsOptShape.Rotation = shape.Rotation;
bsOptShape.Scale = shape.Scale;

bsOptShape.Create(Header.Version, geomData.Vertices, geomData.Triangles, geomData.UVSets, geomData.Normals);
// Honor the withoutNormals flag — ModelSpace shaders must drop normals.
bsOptShape.Create(Header.Version, geomData.Vertices, geomData.Triangles, geomData.UVSets, !withoutNormals ? geomData.Normals : null);
bsOptShape.Flags_ui = shape.Flags_ui;

// Restore old bounds for static meshes or when calc bounds is off
Expand Down
Loading