ci: pass --locked to cargo install --path cargo-pgrx#2292
Open
philippemnoel wants to merge 1 commit into
Open
Conversation
`cargo install --path` ignores `Cargo.lock` unless `--locked` is given,
so every CI run re-resolved transitive deps fresh from crates.io. This
recently started failing on the `verify package can build` job: the
fresh resolution pulled in `rustix 0.37.28`, which uses `#[rustc_attrs]`
attributes that the current nightly compiler rejects with:
error: attributes starting with `rustc` are reserved for use by the
`rustc` compiler
--> rustix-0.37.28/src/backend/linux_raw/io/errno.rs:28:25
`Cargo.lock` on `develop` already pins `rustix 1.1.2`, which builds
fine; the CI just wasn't honoring it.
Add `--locked` to every `cargo install --path cargo-pgrx` invocation
across the three workflow files (5 in tests.yml, 1 in runas.yml, 1 in
package-test.yaml) so CI uses the same resolution as `cargo build` and
becomes reproducible.
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo install --pathdoes not honorCargo.lockunless--lockedis given, so every CI run silently re-resolves all transitive dependencies fresh from crates.io. That just started biting us on the `verify package can build` job — the fresh resolution pulled in `rustix 0.37.28`, whose `#[rustc_attrs]` attributes the current nightly rejects:```
error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
--> rustix-0.37.28/src/backend/linux_raw/io/errno.rs:28:25
|
28 | #[cfg_attr(rustc_attrs, rustc_layout_scalar_valid_range_start(0xf001))]
```
The lockfile on `develop` already pins `rustix 1.1.2`, which builds fine — CI just wasn't honoring it.
This PR adds `--locked` to every `cargo install --path cargo-pgrx` invocation across the three workflow files:
No code changes, no dep changes — just makes CI install pgrx with the same resolution as a normal `cargo build`. The `cargo install cargo-deny --locked` line was already correct and is left alone.
Test plan