stdio/file: fix tmpfile errno setting#476
Open
julianuziemblo wants to merge 1 commit into
Open
Conversation
14 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
julianuziemblo
force-pushed
the
julianuziemblo/#1575
branch
from
9c86dfe to
46f1e20
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the tmpfile function in stdio/file.c to improve error handling and signal interruption management during the lookup of the temporary file device. Specifically, it refines the retry logic for EINTR and ensures errno is correctly set when the lookup fails or the device check is unsuccessful. Feedback suggests using a do-while loop for better readability and adopting the SET_ERRNO macro to maintain consistency with the project's coding standards.
julianuziemblo
force-pushed
the
julianuziemblo/#1575
branch
from
46f1e20 to
0d40de4
Compare
julianuziemblo
force-pushed
the
julianuziemblo/#1575
branch
from
0d40de4 to
a8032f5
Compare
Unit Test Results10 712 tests 10 042 ✅ 51m 52s ⏱️ Results for commit a8032f5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: phoenix-rtos/phoenix-rtos-project#1575
Fixes: phoenix-rtos/phoenix-rtos-project#1417
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment