Skip to content

add tests for tmpfile() and enable lsb_vsx tests for issue #1417#486

Open
julianuziemblo wants to merge 2 commits into
masterfrom
julianuziemblo/#1575
Open

add tests for tmpfile() and enable lsb_vsx tests for issue #1417#486
julianuziemblo wants to merge 2 commits into
masterfrom
julianuziemblo/#1575

Conversation

@julianuziemblo
Copy link
Copy Markdown
Contributor

@julianuziemblo julianuziemblo commented May 20, 2026 •
edited
Loading

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

github-actions[bot]
github-actions Bot reviewed May 20, 2026
View reviewed changes
Comment thread libc/posixsrv/main.c Outdated
@julianuziemblo julianuziemblo mentioned this pull request May 20, 2026
Open
14 tasks
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/#1575 branch from d690aa5 to 1032127 Compare May 20, 2026 09:27
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 20, 2026
View reviewed changes
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces unit tests for the tmpfile() function within the posixsrv component of libc. It includes the creation of a new test suite in libc/posixsrv/tmpfile.c, updates to the build system and test configurations to incorporate these tests, and the enablement of additional LSB VSX test cases. A review comment identified that the expected and actual arguments in a TEST_ASSERT_EQUAL_STRING call were swapped, which would lead to confusing error messages.

Comment thread libc/posixsrv/tmpfile.c Outdated
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/#1575 branch from 1032127 to 42633a8 Compare May 20, 2026 09:29
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026 •
edited
Loading

Unit Test Results (nightly)

     1 files   3 080 suites   5h 46m 22s ⏱️
26 530 tests 22 584 ✅ 3 946 💤 0 ❌
26 716 runs  22 731 ✅ 3 985 💤 0 ❌

Results for commit 5b931b5.

♻️ This comment has been updated with latest results.

@julianuziemblo julianuziemblo force-pushed the julianuziemblo/#1575 branch from 42633a8 to 5b931b5 Compare May 20, 2026 16:27
@julianuziemblo julianuziemblo requested a review from adamdebek May 21, 2026 11:39
This was referenced May 22, 2026
Open
Open
adamdebek
adamdebek requested changes May 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@adamdebek adamdebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small suggestions.

We can remove nightly run since we know it passes, and close the issue if it has been resolved.

Comment thread libc/posixsrv/main.c Outdated
Comment thread libc/posixsrv/tmpfile.c Outdated
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/#1575 branch from 5b931b5 to 663857f Compare May 22, 2026 09:00
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026

Unit Test Results

10 712 tests   10 042 ✅  53m 18s ⏱️
   659 suites     670 💤
     1 files         0 ❌

Results for commit 663857f.

@julianuziemblo julianuziemblo mentioned this pull request May 22, 2026
Draft
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@adamdebek adamdebek adamdebek approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@julianuziemblo @adamdebek