proc/threads: let _proc_lockTry relock a recursive mutex#785
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces recursive locking support in the _proc_lockTry function within proc/threads.c. It adds logic to increment a lock's depth if the current thread already owns a recursive lock. The review feedback identifies a missing overflow check for the lock depth, suggesting an assertion, and recommends using the equality operator for type checks to ensure consistency with the repository's style.
b5e7e7c to
4495913
Compare
14 tasks
etiaro
reviewed
May 22, 2026
44f0732 to
cb14c80
Compare
etiaro
requested changes
May 25, 2026
cb14c80 to
2314c80
Compare
etiaro
reviewed
May 25, 2026
2314c80 to
bf137f0
Compare
bf137f0 to
e79e524
Compare
e79e524 to
cdf9af4
Compare
etiaro
requested changes
May 25, 2026
etiaro
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YT: RTOS-1334
Description
related: phoenix-rtos/libphoenix#477
Tests:
Depends-On: phoenix-rtos-tests:julianuziemblo/CI-676
Motivation and Context
Types of changes
How Has This Been Tested?
ia32-generic-qemuChecklist:
Special treatment