libc/stdio: add tests for flockfile, ftrylockfile, funlockfile#488
Open
julianuziemblo wants to merge 1 commit into
Open
libc/stdio: add tests for flockfile, ftrylockfile, funlockfile#488julianuziemblo wants to merge 1 commit into
julianuziemblo wants to merge 1 commit into
Conversation
This was referenced May 22, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces new unit tests for stdio_flockfile and recursive mutex try-lock functionality. Feedback was provided regarding the robustness of the tests, specifically highlighting a busy-wait loop in the stdio_flockfile test that lacks a timeout and a potential deadlock in the multithreaded mutex test where a thread might exit without releasing a previously acquired lock.
Unit Test Results10 598 tests 9 928 ✅ 52m 29s ⏱️ Results for commit 1ca54b0. ♻️ This comment has been updated with latest results. |
julianuziemblo
changed the title
julianuziemblo
force-pushed
the
julianuziemblo/RTOS-1334
branch
from
09efe82 to
1ca54b0
Compare
Contributor
Author
|
I split this in 2 PRs: this and #489, to make it more managable and the title shorter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YT: RTOS-1334
Description
Motivation and Context
Types of changes
How Has This Been Tested?
ia32-generic-qemuChecklist:
Special treatment