gh-132532: Add CHECK_PERIODIC instruction and use it for CALLs instead of the uop version.#132533
gh-132532: Add CHECK_PERIODIC instruction and use it for CALLs instead of the uop version.#132533iritkatriel wants to merge 11 commits intopython:mainfrom
CHECK_PERIODIC instruction and use it for CALLs instead of the uop version.#132533Conversation
|
@gaogaotiantian this PR adds an instruction (CHECK_PERIODIC) after each call. So now pdb.set_trace() sees that as the next instruction, and thinks it's breaking one line earlier. How do you suggest we fix this? Skip the CHECK_PERIODIC instruction (where would the happen?) |
|
The test_pdb failure is not a real failure. We should just fix(remove) the test. It was a corner case where the instruction after |
|
CHECK_PERIODIC has the same line number as the CALL of set_trace(). So it will look like we stopped just before the set_trace call. I don't think that's what we want. |
|
That is what we want. The existing test that failed is an exception, which stopped at the next line. We put a lot of effort to make |
| try: | ||
| self.assertRaises(ZeroDivisionError, wio.write, large_data) | ||
| with self.assertRaises(ZeroDivisionError): | ||
| wio.write(large_data) |
There was a problem hiding this comment.
I needed to make this change because otherwise the exception is not swallowed (seems that it shows up after the self.assertRaises call has returned).
|
It looks like the |
|
All commit authors signed the Contributor License Agreement. |
|
It looks like |
3 participants
Uh oh!
There was an error while loading. Please reload this page.