Fix nested Concatenate with ellipsis crash#21414
Open
cyphercodes wants to merge 1 commit intopython:masterfrom
Open
Fix nested Concatenate with ellipsis crash#21414cyphercodes wants to merge 1 commit intopython:masterfrom
cyphercodes wants to merge 1 commit intopython:masterfrom
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21404.
This rejects a nested
Concatenate[...]when it appears in the prefix arguments of anotherConcatenate, including theConcatenate[Concatenate[...], ...]crash case from the issue. The existing nested-Concatenate error path only handled theParamSpec-prefix form, so the ellipsis form could reachParameters(...)with anotherParametersobject nested inside it.Tests:
pytest -n0 mypy/test/testcheck.py::TypeCheckSuite::check-parameter-specification.test -k testStackedConcatenateIsIllegal -qpytest -n0 mypy/test/testcheck.py::TypeCheckSuite::check-parameter-specification.test -qpython -m mypy --config-file mypy_self_check.ini mypy/typeanal.pypython -m mypy --config-file mypy_self_check.ini -p mypypre-commit run --files mypy/typeanal.py test-data/unit/check-parameter-specification.testgit diff --check