Skip to content

Fix nested Concatenate with ellipsis crash #21414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cyphercodes wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix nested Concatenate with ellipsis crash #21414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mypy/typeanal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,9 @@ def apply_concatenate_operator(self, t: UnboundType) -> Type:
self.api.fail("Nested Concatenates are invalid", t, code=codes.VALID_TYPE)

args = self.anal_array(t.args[:-1])
if any(isinstance(arg, (Parameters, ParamSpecType)) for arg in args):
self.api.fail("Nested Concatenates are invalid", t, code=codes.VALID_TYPE)
return AnyType(TypeOfAny.from_error)
pre = ps.prefix if isinstance(ps, ParamSpecType) else ps

# mypy can't infer this :(
Expand Down
1 change: 1 addition & 0 deletions test-data/unit/check-parameter-specification.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1147,6 +1147,7 @@ from typing import Callable
P = ParamSpec("P")

def x(f: Callable[Concatenate[int, Concatenate[int, P]], None]) -> None: ... # E: Nested Concatenates are invalid
def y(f: Callable[Concatenate[Concatenate[...], ...], None]) -> None: ... # E: Nested Concatenates are invalid
[builtins fixtures/paramspec.pyi]

[case testPropagatedAnyConstraintsAreOK]
Expand Down
Loading