chore: port Greenplum dialect (#4661)#2673
Merged
Merged
Conversation
This was referenced Jun 6, 2026
Contributor
Benchmark for ceb07a5Click to view benchmark
|
benfdking
force-pushed
the
port/sqlfluff-4653
branch
from
062cb99 to
7dcaa6b
Compare
benfdking
force-pushed
the
port/sqlfluff-4661
branch
from
e92dc58 to
750ccbf
Compare
- SQLFluff #4661 added the Greenplum dialect (a massively parallel Postgres). Ported it to sqruff: new `DialectKind::Greenplum`, `greenplum.rs` (derived from postgres) with the `DISTRIBUTED BY (...) | RANDOMLY | REPLICATED` clause on `CREATE TABLE` and `DISTRIBUTED`/`RANDOMLY`/`REPLICATED` reserved keywords, wired into the dialect registry, feature list, and test harness. - Greenplum storage option values accept literals, bare identifiers, reserved-word identifiers, and quoted identifiers (e.g. `compresstype = zstd`, `orientation = column`, `compresstype = "zstd"`). - Added the `greenplum/create_table` fixture (.sql + .yml); the dialect test parses it with no unparsable segments. Parser-only change. - Follow-up (not in this PR, and not supported by SQLFluff #4661 either): `CREATE TABLE ... AS SELECT ... DISTRIBUTED ...` (CTAS) — the trailing DISTRIBUTED clause needs deeper select parse-mode work. Ported from SQLFluff 32095f823ee6a8b597b3dc8cb688d55449f85b64 sqlfluff/sqlfluff#4661 sqlfluff/sqlfluff@32095f8
benfdking
force-pushed
the
port/sqlfluff-4661
branch
from
750ccbf to
cef49dd
Compare
Contributor
Benchmark for 7848ef5Click to view benchmark
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DialectKind::Greenplum,greenplum.rs(derived from postgres) with theDISTRIBUTED BY (...) | RANDOMLY | REPLICATEDclause onCREATE TABLEandDISTRIBUTED/RANDOMLY/REPLICATEDreserved keywords, wired into the dialect registry, feature list, and test harness.compresstype = zstd,orientation = column,compresstype = "zstd").greenplum/create_tablefixture (.sql + .yml); the dialect test parses it with no unparsable segments. Parser-only change.CREATE TABLE ... AS SELECT ... DISTRIBUTED ...(CTAS) — the trailing DISTRIBUTED clause needs deeper select parse-mode work.Ported from SQLFluff 32095f823ee6a8b597b3dc8cb688d55449f85b64
sqlfluff/sqlfluff#4661
sqlfluff/sqlfluff@32095f8