Show bounty submission requirements on detail page#890
Show bounty submission requirements on detail page#890xiefuzheng713-alt wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe bounty detail template now displays a "Submission requirements" section sourced from ChangesBounty Detail Submission Requirements
Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: fa995ce8-2b63-4208-a11b-6a7c83af0aab
📒 Files selected for processing (2)
app/templates/bounty_detail.htmltests/test_bounty_pages.py
c4de227 to
1fe12ea
Compare
mauricemohr88-debug
left a comment
There was a problem hiding this comment.
Reviewed current head 1fe12ea38352bfdc41501e5579698a919f9c9960.
Approved. I inspected app/templates/bounty_detail.html and tests/test_bounty_pages.py and verified this is a focused bounty-detail UX/test update:
- the new
Submission requirementsblock renders the existing structuredbounty.submission_requirementsdata rather than inventing new lifecycle logic; - claim command, reference formats, and expected artifact are displayed before the existing contributor checklist;
- the active-attempts action now reuses
requirements.attempt_endpoint, matching the serialized requirement metadata for the bounty; - tests cover both the generic PR/evidence requirement shape and issue-specific requirement text such as
/claim #649,Linked bounty: #649, and the proposed-work artifact wording; - no bounty creation, proposal execution, payout execution, ledger mutation, wallet behavior, admin-token API, bridge, exchange, cash-out, MRWK price, private-data, credential, or secret-handling behavior is changed.
Validation on this exact head:
uv run --python 3.12 --extra dev python -m pytest tests/test_bounty_pages.py tests/test_public_routes.py -q-> 25 passed, 1 existing Starlette/httpx warning.uv run --python 3.12 --extra dev ruff check tests/test_bounty_pages.py tests/test_public_routes.py-> passed.uv run --python 3.12 --extra dev ruff format --check tests/test_bounty_pages.py tests/test_public_routes.py-> 2 files already formatted.uv run --python 3.12 --extra dev mypy app/public_routes.py app/serializers.py-> success.uv run --python 3.12 --extra dev python scripts/docs_smoke.py-> docs smoke ok.git diff --check origin/main...HEAD-> clean.git merge-tree --write-tree origin/main HEAD-> clean treead34aab4f34743ef60a02ffa0cbfe9beae3903fd.
GitHub state checked before approval: mergeStateStatus=CLEAN; hosted Quality, readiness, docs, and image checks and CodeRabbit statuses are successful on this head. I found no prior human review and no existing #838 claim for PR #890 / this head before posting this review.
Refs #845
Summary
submission_requirementson bounty detail pages.submission_requirements.attempt_endpointfor the active-attempt action link.Duplicate check
Validation
uv run --python 3.12 --extra dev python -m pytest tests/test_bounty_pages.py tests/test_public_routes.py -q-> 24 passed, 1 existing Starlette/httpx warning.uv run --python 3.12 --extra dev ruff check .-> passed.uv run --python 3.12 --extra dev ruff format --check .-> 111 files already formatted.uv run --python 3.12 --extra dev mypy app-> success across 42 source files.uv run --python 3.12 --extra dev python scripts/docs_smoke.py-> docs smoke ok.git diff --check origin/main...HEAD-> clean.git merge-tree --write-tree origin/main HEAD-> clean tree02eae5dd9df3521c623ee28326dd9627463da75b.Scope
Bounty detail template and page regression coverage only. No bounty creation, proposal execution, payout execution, ledger mutation, wallet behavior, admin-token APIs, exchange, bridge, off-ramp, cash-out, MRWK price behavior, private data, or secrets changed.
Summary by CodeRabbit
New Features
Improvements