Skip to content

Fix several user-facing messages not marked as translated #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kisaragi-hiu wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −7
Open

Fix several user-facing messages not marked as translated #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions po/POTFILES.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ src/dialogs/task_manager_dialog.rs
src/widgets/container_overview.rs
src/widgets/image_row_item.rs
src/widgets/integrated_terminal.rs
src/widgets/tasks_button.rs
src/widgets/terminal_combo_row.rs
src/widgets/welcome_view.rs
src/widgets/welcome_view.ui
Expand Down
8 changes: 4 additions & 4 deletions src/dialogs/create_distrobox_dialog.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,11 +190,11 @@ mod imp {

// Add pages to view stack
self.view_stack
.add_titled(&guided_page, Some("create"), "Guided");
.add_titled(&guided_page, Some("create"), &gettext("Guided"));
self.view_stack
.add_titled(&assemble_page, Some("assemble-file"), "From File");
.add_titled(&assemble_page, Some("assemble-file"), &gettext("From File"));
self.view_stack
.add_titled(&url_page, Some("assemble-url"), "From URL");
.add_titled(&url_page, Some("assemble-url"), &gettext("From URL"));

// Create a box to hold the view switcher and content
let content_box = gtk::Box::new(gtk::Orientation::Vertical, 0);
Expand Down Expand Up @@ -225,7 +225,7 @@ mod imp {
toolbar_view.set_vexpand(true);
toolbar_view.set_content(Some(&self.toast_overlay));

let page = adw::NavigationPage::new(toolbar_view, "Create a Distrobox");
let page = adw::NavigationPage::new(toolbar_view, &gettext("Create a Distrobox"));
navigation_view.add(&page);
self.obj().set_child(Some(navigation_view));

Expand Down
4 changes: 2 additions & 2 deletions src/dialogs/task_manager_dialog.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ mod imp {

self.navigation_view.add(&adw::NavigationPage::new(
&self.toolbar_view,
"Manage Tasks",
&gettext("Manage Tasks"),
));
let this = self.obj().clone();
if root_store.tasks().is_empty() {
Expand Down Expand Up @@ -135,7 +135,7 @@ mod imp {
}
this.imp()
.navigation_view
.push(&adw::NavigationPage::new(stv, "Task Details"));
.push(&adw::NavigationPage::new(stv, &gettext("Task Details")));
}
});
let this = self.obj().clone();
Expand Down
3 changes: 2 additions & 1 deletion src/widgets/tasks_button.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::i18n::gettext;
use crate::models::{DialogType, DistroboxTask, RootStore};
use adw::prelude::*;
use adw::subclass::prelude::*;
Expand Down Expand Up @@ -44,7 +45,7 @@ mod imp {

// Create a horizontal box with a "Tasks" label and warning icon
let hbox = gtk::Box::new(gtk::Orientation::Horizontal, 6);
let label = gtk::Label::new(Some("Tasks"));
let label = gtk::Label::new(Some(&gettext("Tasks")));
let warning_icon = &self.warning_icon;
warning_icon.set_hexpand(true);
warning_icon.set_halign(gtk::Align::End);
Expand Down