rebase

[Abhinavpv28]

No description provided.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

✅ nhanasi
✅ venkat0557
✅ Abhinavpv28
✅ AravindanNC
✅ Alan-Ryan
❌ naveenkumarhanasi
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[Copilot]

Pull request overview

This PR is a rebase containing multiple feature additions and improvements to the Remote Debugger component, including:

• Enhanced L2 test coverage with new test scenarios for dynamic subcategory reports, deep sleep, and append functionality
• Deep sleep event handling support with power manager integration
• Unit test infrastructure improvements with comprehensive mock support
• Documentation additions for uploadRRDLogs migration to C
• Build system updates and workflow improvements

Key Changes

• New L2 test files for dynamic profiles, deep sleep scenarios, and append operations
• Enhanced PID handling in single instance tests with proper parsing
• Deep sleep event processing with power controller integration
• Memory management improvements in event processing
• Comprehensive unit test coverage expansion
• New mock infrastructure for power manager testing

Reviewed changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
test/functional-tests/tests/test_rrd_single_instance.py	Enhanced PID handling with proper list parsing and validation
test/functional-tests/tests/test_rrd_dynamic_subcategory_report.py	New L2 test for dynamic profile subcategory reports
test/functional-tests/tests/test_rrd_deepsleep_static_report.py	New L2 test for deep sleep static reports
test/functional-tests/tests/test_rrd_append_report.py	New L2 test for append request scenarios
test/functional-tests/tests/power_controller.h	New power controller API definitions for deep sleep
test/functional-tests/tests/deepsleep_main.c	Test main for deep sleep event handling
src/rrdRunCmdThread.c	Added RemainAfterExit flag to systemd-run commands
src/rrdJsonParser.c	Added deep sleep detection logic
src/rrdInterface.h/c	Interface updates for IARM support compilation
src/rrdIarmEvents.c	Refactored power manager event handling
src/rrdEventProcess.c	Improved memory management with null checks
src/rrdDynamic.c	Fixed buffer size calculation in string copy
src/unittest/rrdUnitTestRunner.cpp	Extensive unit test additions and mock updates
src/unittest/mocks/*.h/cpp	Updated mock infrastructure for testing
docs/*.md	New comprehensive documentation for uploadRRDLogs
configure.ac	Added L2 support configuration option
cov_build.sh	Updated build flags for coverage
CHANGELOG.md	Version updates and changelog entries
.github/workflows/*	Workflow improvements and CLA addition

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Variable issue_string is not used.

[Copilot]

Import pollutes the enclosing namespace, as the imported module helper_functions does not define 'all'.

[Copilot]

Import pollutes the enclosing namespace, as the imported module helper_functions does not define 'all'.

[Copilot]

Import pollutes the enclosing namespace, as the imported module helper_functions does not define 'all'.

[Copilot]

Import of 'json' is not used.

[Copilot]

Pull request overview

Copilot reviewed 62 out of 62 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Variable node is not used.

[Copilot]

Variable subnode is not used.

[Copilot]

Variable ISSUE_FOUND is not used.

[Copilot]

Import pollutes the enclosing namespace, as the imported module helper_functions does not define 'all'.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 63 out of 63 changed files in this pull request and generated 9 comments.

[Copilot]

This test module performs file I/O and overwrites /etc/rrd/remote_debugger.json at import time. If the file is missing or the test runner lacks permissions, collection will fail before any tests run, and it also makes the suite order-dependent. Move this JSON read/update/write logic into a dedicated test (or a setup/fixture) and prefer writing to a temporary copy of the config rather than mutating /etc directly.

[Copilot]

processIssueType() allocates pIssueNode via malloc() but it is never freed on any path (the previous free(pIssueNode) was removed). Since this runs per event, this introduces an unbounded memory leak in the daemon. Ensure pIssueNode is freed before returning (including error paths), and avoid freeing it inside helpers that don't own it.

[Copilot]

rrd_upload_cleanup_source_dir() builds a shell command and calls system("rm -rf %s"). This is vulnerable to command injection if dir_path contains shell metacharacters, and it also violates the project's stated goal of avoiding system() calls where possible. Replace this with a safe recursive deletion implementation (e.g., nftw()/unlinkat() traversal) and validate that dir_path is within an expected base directory before deleting.

[Copilot]

write_tar_header() splits long paths into prefix/name by taking an arbitrary cut (prefix_len = name_len - 101). This doesn't respect tar's requirement that the split occur on a '/' boundary, and can produce archives with invalid/incorrect entry names for paths >100 chars. Prefer splitting at the last '/' that keeps prefix<=155 and name<=100 (or reject paths that can't be represented).

Suggested change

	/* split into prefix and name */
	size_t prefix_len = name_len - 100 - 1; /* leave room for null */
	if (prefix_len > sizeof(hdr.prefix)) {
	RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s] File name too long: %s (length %zu)\n",
	__FUNCTION__, name, name_len);
	return -1;
	}
	strncpy(hdr.prefix, name, prefix_len);
	hdr.prefix[prefix_len < sizeof(hdr.prefix) ? prefix_len : sizeof(hdr.prefix) - 1] = '\0';
	strncpy(hdr.name, name + prefix_len + 1, sizeof(hdr.name) - 1);
	hdr.name[sizeof(hdr.name) - 1] = '\0';
	/* split into prefix and name at a '/' boundary according to POSIX ustar */
	size_t split_index = (size_t)-1;
	size_t prefix_len = 0;
	size_t name_part_len = 0;
	/* search for the rightmost '/' that yields valid prefix/name lengths */
	for (size_t i = name_len; i > 0; --i) {
	if (name[i - 1] == '/') {
	size_t p_len = i - 1; /* characters before '/' */
	size_t n_len = name_len - i; /* characters after '/' */
	if (p_len > 0 &&
	p_len <= sizeof(hdr.prefix) - 1 &&
	n_len > 0 &&
	n_len <= sizeof(hdr.name) - 1) {
	split_index = i - 1;
	prefix_len = p_len;
	name_part_len = n_len;
	break;
	}
	}
	}
	if (split_index == (size_t)-1) {
	RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s] File name too long: %s (length %zu)\n",
	__FUNCTION__, name, name_len);
	return -1;
	}
	/* copy prefix and name parts, ensuring null termination */
	strncpy(hdr.prefix, name, prefix_len);
	hdr.prefix[prefix_len] = '\0';
	strncpy(hdr.name, name + split_index + 1, name_part_len);
	hdr.name[name_part_len] = '\0';

[Copilot]

This appends the mock MAC to /tmp/.estb_mac on every run, which will accumulate multiple lines and can break any code that expects a single MAC value. Use overwrite (>) or truncate the file before writing the mock MAC.

Suggested change

	echo "AA:BB:CC:DD:EE:FF" >> /tmp/.estb_mac
	echo "AA:BB:CC:DD:EE:FF" > /tmp/.estb_mac

[Copilot]

Typo in step text: "shopuld" should be "should".

[Copilot]

Typo in enum comment: "Critial" should be "Critical".

[Copilot]

Typo in step text: "shopuld" should be "should".

[Copilot]

The boolean name is_prod_with_override doesn't match its condition (BUILD_TYPE != prod && /opt/dcm.properties exists). This makes the override logic hard to reason about and easy to misread. Rename it to reflect the actual condition (e.g., non_prod_with_opt_dcm_override) or adjust the condition to match the name.