RDKEMW-12059: Fix Coverity identified issues#192
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses static-analysis (Coverity) findings across the GDial server by adding targeted suppressions and small code adjustments to reduce false positives and flagged patterns.
Changes:
- Add error-check logging around app-cache erase operations.
- Add Coverity suppression annotations for specific reported issues (printf args, deadcode, url manipulation, parameter hidden).
- Remove a redundant pointer nullification in the unit-test executable.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| server/plat/gdialappcache.cpp | Adds an erase() return-code check/logging before inserting into the cache. |
| server/plat/gdial-plat-util.c | Adds a Coverity suppression for a printf_args report in logging. |
| server/gdialserver_ut.cpp | Removes a redundant testObject = nullptr; assignment after delete. |
| server/gdial-rest.c | Adds Coverity suppressions around dead-code paths and origin validation checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for Change: Suppressed the Coverity identified issues
Risks: Low
Priority: P2
Signed-off-by:Dineshkumar P [dinesh_kumar2@comcast.com]