RDKEMW-12059: Fix Coverity identified issues

server/gdial-rest.c

@@ -501,6 +501,7 @@ static void gdial_rest_server_handle_POST(GDialRestServer *gdial_rest_server, So
      * start_error = NONE;
      * app exist, and could be in hidden state, so resume;
      */
+    /* coverity[deadcode : FALSE] */
     start_error = gdial_app_start(app, NULL, NULL, NULL, gdial_rest_server);
   }
 
@@ -535,6 +536,7 @@ static void gdial_rest_server_handle_POST(GDialRestServer *gdial_rest_server, So
       }
     }
     else {
+      /* coverity[deadcode : FALSE] */
       soup_message_set_status(msg, SOUP_STATUS_OK);
     }
   }
@@ -880,7 +882,9 @@ static void gdial_rest_http_server_apps_callback(SoupServer *server,
 
   const gchar *header_origin = soup_message_headers_get_one(msg->request_headers, "Origin");
   GDIAL_LOGERROR("Origin %s, Host: %s, Method: %s", header_origin, header_host, msg->method);
+  /* coverity[url_manipulation : FALSE] */
   if (!gdial_rest_server_is_allowed_origin(gdial_rest_server, header_origin, app_name)) {
+    /* coverity[PW.PARAMETER_HIDDEN : FALSE] */
     gdial_rest_server_http_print_and_return_if_fail(FALSE, msg, SOUP_STATUS_FORBIDDEN, "origin %s is not allowed", header_origin);
   }
   /*

server/gdialserver_ut.cpp

@@ -224,7 +224,6 @@ int main(int argc, char *argv[])
             if (nullptr != testObject)
             {
                 delete testObject;
-                testObject = nullptr;
             }
             testObject = new gdialServiceTest(gdial_args);
         }

server/plat/gdial-plat-util.c

@@ -123,6 +123,7 @@ void gdial_plat_util_log(gdial_plat_util_LogLevel level,
     fprintf(stderr, "[GDIAL][%ld] %s [%s:%d] %s: %s \n",
                 (long)syscall(SYS_gettid),
                 levelMap[level],
+                /* coverity[PRINTF_ARGS : FALSE] */
                 basename(file),
                 line,
                 func,

server/plat/gdialappcache.cpp

@@ -74,6 +74,10 @@ AppCacheErrorCodes GDialAppStatusCache::UpdateAppStatusCache(AppInfo* appEntry)
     if(doIdExist(id)) {
         GDIAL_LOGINFO("erasing old data");
         err = ObjectCache->erase(id);
+        if(err != AppCacheError_OK)
+        {
+            GDIAL_LOGINFO("erasing failed");
+        }
     }
     err = ObjectCache->insert(std::move(id),appEntry);
     GDIAL_LOGTRACE("Exiting ...");