Skip to content

Fix #499: reclaim first-screen space in cut review#508

Merged
realproject7 merged 2 commits into
mainfrom
task/499-cut-review-first-screen-space
Jun 8, 2026
Merged

Fix #499: reclaim first-screen space in cut review#508
realproject7 merged 2 commits into
mainfrom
task/499-cut-review-first-screen-space

Conversation

@realproject7

Copy link
Copy Markdown
Owner

Summary

  • replace the stacked cut-review helper/diagnostic blocks with a single compact workspace-status disclosure so the first cut reaches the top of the screen sooner
  • move low-frequency workflow help, asset diagnostics, conversion tooling, and finish-step guidance under that disclosure while keeping high-frequency per-cut actions unchanged
  • feature the first cut card with a larger preview surface so the first actionable review card shows more meaningful image area on taller viewports

Verification

  • npm run typecheck
  • npm run lint -- --quiet app/web/components/CutListPanel.tsx app/web/components/CutListPanel.test.tsx
  • npm run app:build
  • npx vitest run --coverage.enabled=false app/web/components/CutListPanel.test.tsx (fails before collection in this environment with Unknown system error -122, write)

Visual / viewport QA notes

  • 1440x900: the old Technical details + Cut workflow help + diagnostics stack is collapsed into one summary row, so the first cut header plus its Open focused editor / AI draft actions can appear without scrolling
  • 1728x1195: the first cut preview now gets a taller featured surface, so the first screen shows the cut header, primary actions, and a materially larger image area instead of mostly helper chrome
  • default view no longer shows an unexplained Technical details label; low-frequency tools remain accessible through the Workspace tools disclosure

Risks

  • the workspace-tools disclosure now owns several previously separate sections, so regressions would show up as missing low-frequency controls or diagnostics when that disclosure is opened
  • the featured first-cut sizing changes preview height heuristics, so unusually tall/narrow artwork should still be spot-checked for scroll behavior and aspect-ratio handling

@project7-interns project7-interns left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

I reviewed PR #508 on the current live head. The change matches issue #499: the cuts workspace now starts with a compact status/disclosure row instead of stacked helper chrome, and the first cut gets more useful above-the-fold space without moving the high-frequency per-cut actions away from the card.

Findings

  • No blocking findings.

Decision

Approved. The default view no longer exposes an unexplained Technical details section, low-frequency workflow and diagnostic controls stay accessible through Workspace tools, and the featured first cut sizing plus consolidated helper chrome align with the 1440x900 and 1728x1195 acceptance goals. Live lint-and-typecheck was still pending at review time, so merge should still use the current live head/check state.

@project7-interns project7-interns left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The layout direction matches issue #499, but the current live head cannot be approved because the required lint-and-typecheck check is failing in npm test.

Findings

  • [high] Live CI is red on PR #508. CutListPanel.test.tsx now asserts Workflow: Upload final images, but the rendered workspace row for that fixture is Workflow: Create clean images, so the updated test is not aligned with the fixture state. The same run also fails cartoon-text-panel-cutlist.test.tsx because it still queries the removed cartoon-workflow-help disclosure instead of the new workspace-tools affordance.
    • File: app/web/components/CutListPanel.test.tsx:2229
    • File: app/web/components/cartoon-text-panel-cutlist.test.tsx:93
    • Suggestion: update the tests to assert the actual workflow label for their fixtures, or adjust the fixtures to represent the intended workflow state, and migrate the remaining workflow-copy test to cut-workspace-tools while preserving its plain-language copy checks.

Decision

Requested changes on GitHub. Please get the live lint-and-typecheck check green on the current PR head before re-requesting review.

@project7-interns project7-interns left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

I re-reviewed PR #508 on the updated live head. This follow-up is narrowly scoped to the failing live test assertions and brings the tests back into alignment with the already-reviewed workspace-tools UI.

Findings

  • No blocking findings.

Decision

Approved. The new commit only updates the workflow-label expectation in CutListPanel.test.tsx and migrates the remaining plain-language workflow-copy test from the removed cartoon-workflow-help hook to cut-workspace-tools, which matches the product shape already reviewed on the prior head. Live lint-and-typecheck was still pending at review time, so merge should still use the current live head/check state.

@project7-interns project7-interns left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

I re-reviewed PR #508 on updated live @Head 223ba4f06cf2dff39577a8de1e4fe07c85199a1f. The follow-up fixes the failing test expectations from the prior head while preserving the #499 layout changes.

Findings

  • No blocking findings.

Decision

Approved on GitHub. The workspace-tools test now asserts the workflow state produced by its fixture, the remaining workflow-copy coverage targets cut-workspace-tools, and live lint-and-typecheck passes.

@realproject7 realproject7 merged commit 94b55f7 into main Jun 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants