Fix #499: reclaim first-screen space in cut review#508
Conversation
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
I reviewed PR #508 on the current live head. The change matches issue #499: the cuts workspace now starts with a compact status/disclosure row instead of stacked helper chrome, and the first cut gets more useful above-the-fold space without moving the high-frequency per-cut actions away from the card.
Findings
- No blocking findings.
Decision
Approved. The default view no longer exposes an unexplained Technical details section, low-frequency workflow and diagnostic controls stay accessible through Workspace tools, and the featured first cut sizing plus consolidated helper chrome align with the 1440x900 and 1728x1195 acceptance goals. Live lint-and-typecheck was still pending at review time, so merge should still use the current live head/check state.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The layout direction matches issue #499, but the current live head cannot be approved because the required lint-and-typecheck check is failing in npm test.
Findings
- [high] Live CI is red on PR #508.
CutListPanel.test.tsxnow assertsWorkflow: Upload final images, but the rendered workspace row for that fixture isWorkflow: Create clean images, so the updated test is not aligned with the fixture state. The same run also failscartoon-text-panel-cutlist.test.tsxbecause it still queries the removedcartoon-workflow-helpdisclosure instead of the new workspace-tools affordance.- File:
app/web/components/CutListPanel.test.tsx:2229 - File:
app/web/components/cartoon-text-panel-cutlist.test.tsx:93 - Suggestion: update the tests to assert the actual workflow label for their fixtures, or adjust the fixtures to represent the intended workflow state, and migrate the remaining workflow-copy test to
cut-workspace-toolswhile preserving its plain-language copy checks.
- File:
Decision
Requested changes on GitHub. Please get the live lint-and-typecheck check green on the current PR head before re-requesting review.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
I re-reviewed PR #508 on the updated live head. This follow-up is narrowly scoped to the failing live test assertions and brings the tests back into alignment with the already-reviewed workspace-tools UI.
Findings
- No blocking findings.
Decision
Approved. The new commit only updates the workflow-label expectation in CutListPanel.test.tsx and migrates the remaining plain-language workflow-copy test from the removed cartoon-workflow-help hook to cut-workspace-tools, which matches the product shape already reviewed on the prior head. Live lint-and-typecheck was still pending at review time, so merge should still use the current live head/check state.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
I re-reviewed PR #508 on updated live @Head 223ba4f06cf2dff39577a8de1e4fe07c85199a1f. The follow-up fixes the failing test expectations from the prior head while preserving the #499 layout changes.
Findings
- No blocking findings.
Decision
Approved on GitHub. The workspace-tools test now asserts the workflow state produced by its fixture, the remaining workflow-copy coverage targets cut-workspace-tools, and live lint-and-typecheck passes.
Summary
Verification
npm run typechecknpm run lint -- --quiet app/web/components/CutListPanel.tsx app/web/components/CutListPanel.test.tsxnpm run app:buildnpx vitest run --coverage.enabled=false app/web/components/CutListPanel.test.tsx(fails before collection in this environment withUnknown system error -122, write)Visual / viewport QA notes
1440x900: the oldTechnical details+Cut workflow help+ diagnostics stack is collapsed into one summary row, so the first cut header plus itsOpen focused editor/AI draftactions can appear without scrolling1728x1195: the first cut preview now gets a taller featured surface, so the first screen shows the cut header, primary actions, and a materially larger image area instead of mostly helper chromeTechnical detailslabel; low-frequency tools remain accessible through theWorkspace toolsdisclosureRisks