Skip to content

Fix #499: reclaim first-screen space in cut review #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realproject7 merged 2 commits into from
Jun 8, 2026
Merged

Fix #499: reclaim first-screen space in cut review #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b732366
Reclaim first-screen space in cut review
realproject7 Jun 8, 2026
223ba4f
Fix cut review test expectations
realproject7 Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions app/web/components/CutListPanel.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1861,7 +1861,7 @@
authFetch={mockAuthFetch({ ok: true, data: cutsData })}
/>,
);
await screen.findByTestId("cartoon-workflow-help");
await screen.findByTestId("cut-workspace-tools");
expect(
screen.queryByTestId("stale-bubble-export-warning"),
).not.toBeInTheDocument();
Expand All @@ -1881,7 +1881,7 @@
authFetch={mockAuthFetch({ ok: true, data: cutsData })}
/>,
);
await screen.findByTestId("cartoon-workflow-help");
await screen.findByTestId("cut-workspace-tools");
expect(
screen.queryByTestId("stale-bubble-export-warning"),
).not.toBeInTheDocument();
Expand Down Expand Up @@ -1989,7 +1989,7 @@

// #441: a PNG clean image is a friendly conversion step, not a red error.
it("shows a Convert artwork step for PNG clean images instead of red unsupported-extension errors", async () => {
const fn = vi.fn((url: string, opts?: RequestInit) => {

Check warning on line 1992 in app/web/components/CutListPanel.test.tsx

View workflow job for this annotation

GitHub Actions / lint-and-typecheck 

'opts' is defined but never used
if (url.includes("/asset-diagnostics")) {
return Promise.resolve({
ok: true,
Expand Down Expand Up @@ -2098,7 +2098,7 @@
// card per cut with a creator-facing status + primary action, technical
// controls collapsed by default.
it("renders an episode header, progress summary, per-cut card statuses, and collapses technical controls", async () => {
const fn = vi.fn((url: string, opts?: RequestInit) => {

Check warning on line 2101 in app/web/components/CutListPanel.test.tsx

View workflow job for this annotation

GitHub Actions / lint-and-typecheck 

'opts' is defined but never used
if (url.includes("/asset-diagnostics")) {
return Promise.resolve({
ok: true,
Expand Down Expand Up @@ -2221,15 +2221,17 @@
"Between-scene lettering",
);

// Technical controls live under a collapsed-by-default Details disclosure.
const advanced = screen.getByTestId("cut-advanced");
expect(advanced.tagName.toLowerCase()).toBe("details");
expect(advanced).not.toHaveAttribute("open");
expect(within(advanced).getByTestId("sync-clean-btn")).toBeInTheDocument();
const help = screen.getByTestId("cartoon-workflow-help");
expect(help.tagName.toLowerCase()).toBe("details");
expect(help).not.toHaveAttribute("open");
expect(within(help).getByText("Cut workflow help")).toBeInTheDocument();
// Low-frequency workflow controls are collapsed into one workspace-tools disclosure.
const tools = screen.getByTestId("cut-workspace-tools");
expect(tools.tagName.toLowerCase()).toBe("details");
expect(tools).not.toHaveAttribute("open");
expect(within(tools).getByTestId("sync-clean-btn")).toBeInTheDocument();
expect(
within(tools).getByText(/Workflow: Create clean images/i),
).toBeInTheDocument();
expect(
screen.queryByText(/^Technical details$/i),
).not.toBeInTheDocument();
expect(screen.getByTestId("finish-episode-details")).not.toHaveAttribute(
"open",
);
Expand Down
Loading
Loading