Teach `concat!()` to concatenate byte str literals by estebank · Pull Request #52838 · rust-lang/rust

estebank · 2018-07-29T23:39:45Z

Fix #52710.

…ents

…NonZeroU*

rfc, const-repeat-expr: notes on is_rvalue_promotable(expr)

Issues are not feature requests

Add missing Copy bound for K in get_default in RFC 2094

Markdown style link for mdbook (same as rust-lang#2199)

Stable SIMD in Rust

Allow `loop` in constant evaluation

Update RFC 0430 to allow underscores between numbers in CamelCase names

The Cretonne project is now renamed to Cranelift. Update the names in the SIMD RFC and add links to the project page.

Rename Cretonne to Cranelift.

Fix link in RFC template and stuff

…unds RFC: Associated type bounds of form `MyTrait<AssociatedType: Bounds>`

rust-highfive · 2018-07-29T23:39:55Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

estebank · 2018-07-29T23:40:04Z

CC @rust-lang/lang

kennytm · 2018-07-30T00:05:03Z

I think the new behavior of concat! should be placed behind a feature gate.

eddyb · 2018-07-30T08:48:02Z

src/libsyntax/ast.rs

        }
    }

+    /// Returns a `LitKind::ByteStr` from `content`.


Why does this need to have a constructor method, specifically?

eddyb · 2018-07-30T08:48:40Z

src/libsyntax_ext/concat.rs

+    if b_accumulator.len() > 0 {
+        base::MacEager::expr(cx.expr_lit(
+            sp,
+            ast::LitKind::new_byte_str(b_accumulator),


You might want instead a cx.expr_byte_str.

estebank · 2018-07-31T17:40:00Z

I think the new behavior of concat! should be placed behind a feature gate.

@kennytm other than bad style of introducing insta-stable behavior, do you foresee any problems with the new behavior? If the PR also included support to mix and match "" and b"" (which can be done, we just need to figure out what the appropriate default behavior should be and probably add a lint about it being supported but discouraged), I would definitely agree, but as it is I feel the change is small enough not to warrant a long release cycle.

joshtriplett · 2018-07-31T17:55:23Z

@estebank The usual concern there would be if there's some subtle aspect of the new behavior that we don't catch before shipping it, people start relying on that aspect, and we then can't change it even if we want to.

estebank · 2018-07-31T18:05:45Z

src/libsyntax_ext/concat.rs

Just noticed that this error (and suggestion) will be wrong when doing concat!(b"asdf", true, 3).

estebank · 2018-08-01T03:31:06Z

Oh boy... I really messed this up, trying to push to the RFCS repo. Refiled at #52932.

Centril and others added 30 commits February 15, 2018 06:28

rfc, prior-art: communicate intentional divergence per @wycats's comm…

e225f1b

…ents

rfc, prior-art: add drawback of longer template per @est31's comments

7e9d70d

Markdown style link for mdbook

e806302

Type alias enum variants

1a05e39

rename

3b35bc0

pare down cargo parts

a6f0074

rm fuzz

c6a3982

num::NonZero* alternative: drop signed NonZeroI*, only keep unsigned …

b12dc8c

…NonZeroU*

Remove semver selection

492e63b

remove custom profiles

ce15684

rfc, const-repeat-expr: notes on is_rvalue_promotable(expr)

38d278e

Merge pull request rust-lang#1 from Centril/patch-const-repeat-1

8928d68

rfc, const-repeat-expr: notes on is_rvalue_promotable(expr)

rfc, self-in-typedefs: discuss @burdges alternative

f9e6622

rfc, self-in-typedefs: discuss the meaning of Self more

bee4e5b

rfc, self-in-typedefs: add notes about the unresolved question

6c42072

Merge pull request rust-lang#2299 from Manishearth/issues

1706316

Issues are not feature requests

Allow locals and destructuring in const fn

a048a3e

Allow if and match in constants

3a57a13

Discuss match in the reference level explanation

e5cca9f

Add a comment about !Copy types in let bindings in constants

0f24c33

.cargo/config

e3f0e86

Allow loop in constant evaluation

bcffd35

Address comments

5d3d23d

Allow panicking in constants

9ed92f8

Merge pull request rust-lang#2258 from xfix/patch-3

0d978a0

Add missing Copy bound for K in get_default in RFC 2094

Merge pull request rust-lang#2336 from ordovicia/md-link

2bfe17d

Markdown style link for mdbook (same as rust-lang#2199)

Clarify the slicing operation.

8b1171c

fix some typos in rfc1216

a72af80

RFC 2325

7ce3862

Merge pull request rust-lang#2325 from alexcrichton/simd

27f4519

Stable SIMD in Rust

Centril and others added 9 commits July 2, 2018 20:32

RFC 2344

e4ac9b0

Merge pull request rust-lang#2344 from oli-obk/const_looping

c794c75

Allow `loop` in constant evaluation

Merge pull request rust-lang#2478 from pyfisch/patch-1

e978a8d

Update RFC 0430 to allow underscores between numbers in CamelCase names

Rename Cretonne to Cranelift.

762cf58

The Cretonne project is now renamed to Cranelift. Update the names in the SIMD RFC and add links to the project page.

Merge pull request rust-lang#2499 from sunfishcode/master

2a0a320

Rename Cretonne to Cranelift.

Fix link in RFC template and stuff

cc2faf7

Merge pull request rust-lang#2501 from rust-lang/Centril-patch-1

0412428

Fix link in RFC template and stuff

RFC 2289

2a685b5

Merge pull request rust-lang#2289 from Centril/rfc/associated-type-bo…

2d5218a

…unds RFC: Associated type bounds of form `MyTrait<AssociatedType: Bounds>`

rust-highfive assigned nikomatsakis Jul 29, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2018

estebank force-pushed the byte-concat branch from 57cd854 to 6d53cde Compare July 29, 2018 23:42

This comment has been minimized.

Sign in to view

estebank force-pushed the byte-concat branch from 6d53cde to 29a63fb Compare July 30, 2018 00:55

eddyb reviewed Jul 30, 2018

View reviewed changes

estebank force-pushed the byte-concat branch from 2d571ba to 764ca0d Compare July 31, 2018 17:35

estebank commented Jul 31, 2018

View reviewed changes

This comment has been minimized.

Sign in to view

estebank force-pushed the byte-concat branch from 79be938 to 81f402f Compare July 31, 2018 18:27

RFC: Teach concat!() to join [u8] and byte str

ba2d9d7

estebank closed this Aug 1, 2018

estebank force-pushed the byte-concat branch from 2ab6205 to ba2d9d7 Compare August 1, 2018 03:22

estebank mentioned this pull request Aug 1, 2018

Teach concat!() to concatenate byte str literals #52932

Closed

Uh oh!

Conversation

estebank commented Jul 29, 2018

Uh oh!

rust-highfive commented Jul 29, 2018

Uh oh!

estebank commented Jul 29, 2018

Uh oh!

kennytm commented Jul 30, 2018

Uh oh!

This comment has been minimized.

eddyb Jul 30, 2018

Choose a reason for hiding this comment

Uh oh!

estebank Jul 31, 2018

Choose a reason for hiding this comment

Uh oh!

eddyb Jul 30, 2018

Choose a reason for hiding this comment

Uh oh!

estebank Jul 31, 2018

Choose a reason for hiding this comment

Uh oh!

estebank commented Jul 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joshtriplett commented Jul 31, 2018

Uh oh!

estebank Jul 31, 2018

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

estebank commented Aug 1, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Comments

estebank commented Jul 31, 2018 •

edited

Loading