Teach concat!() to concatenate byte str literals#52932
Closed
estebank wants to merge 5 commits intorust-lang:masterfrom
Closed
Teach concat!() to concatenate byte str literals#52932estebank wants to merge 5 commits intorust-lang:masterfrom
concat!() to concatenate byte str literals#52932estebank wants to merge 5 commits intorust-lang:masterfrom
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
RFC for follow up at rust-lang/rfcs#2509. |
Member
|
Hmm our policy is that we won't keep PRs blocked on RFCs open when the PR went idle. |
Contributor
Author
|
@kennytm the RFC is proposing a superset of these changes, this PR only adds support for |
Contributor
Author
|
Will close and await for the RFC process, since the first comment there is already to separate the functionality into its own macro, and honestly having slept on it it feels like the right approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messed up #52838, so reopening here.
Fix #52710.