Conversation
|
I think the textarea should push this: 
Besides, the inputs still seem to have a different height and hence also different gaps between the components. There also seems to be an unnecessary gap below the advanced section / the textarea, which is apparent when scrollable. 
The lobby list should have some kind of min-height, given the create element is scrollable too. As is, the list is inaccessible in certain display sizes: 
On a wide setup the buttons vanish: 
As for the changes in the lobby list, I think the color red isn't the nicest choice. Red means error or attention. So far the page only uses this for the system messages. Starting a game is something positive, so if we color the button, I think green would be nice :) The hover effect seems to indicate clickability of the container, which is not the case. I think if you want that effect, it should be on the button? It also doesn't seem to round the drop shadow correctly: 
I've also noticed, you applied a |
|
Hm I was thinking, maybe we'd save ourselves a lot of layouting work if we just had like a main menu thing where you could switch back and forth. Initially I actually had something like that, there was a tab pane with a create and join tab, but i decided to remove it ... maybe that was dumb. |
|
I pushed a fix for all of your points while retaining the current layout 😄 |
|
I am gonna make some more changes, I think the back and forth would be quite annoying, so i'll keep the rest simple. Gonna make some small layout changes and add more validation and configurabiltiy. |
Additional changes: * advanced section now initially collapsed * consistent component height in lobby creation elements, without hardcoded values > This broke the transitions, but its worth it * delete obsolete styling that didn't do anything * delete random inconsistent spacing * rename `MAX_CUSTOM_WORDS_PER_TURN` to `MAX_WORDS_PER_TURN` * max word per turn and custom words per turn now have the same upper bound, which is 6 by default * max words per turn must be greater or equal to custom words per turn * max words per turn can now be changed mid-game * remove incorrect percentage symbol when changing lobby settings * add title / alt to language flag * fix loss of scoring choice when inputting an incorrect value
|
I have made changes and merged manually. Thanks for the pr btw. Also, in the future, please don't merge changes in, rebase and force push. Otherwise it's quite the pain to merge back, due to github saying there's conflicts, when there are none :D |
|
FYI, I'll be releasing on the weekend if no issues occur :) |
2 participants
Closes #354, Closes #399
Key items implemented by this PR:
EditableLobbySettingsstruct to consolidate params passed toLobby.CreateLobbyto improve readability and make the number of params a bit more manageable.