feat(ui): bevindingen aanmaken via UI op /beheer/bevindingen#81
Merged
Conversation
Voorheen kon je bevindingen alleen via API (`POST /assessments/findings/`) aanmaken — de UI op /beheer/bevindingen was lees-only met filter. Voor audit-/QA-rol-stakeholders een wezenlijke gap. Backend werkt al. Wat erbij komt: - "Nieuwe bevinding" knop bovenaan /beheer/bevindingen - Create-form met verplichte velden: assessment (dropdown), titel, ernst (laag/midden/hoog/kritiek), status (open/in_behandeling/afgesloten); optionele beschrijving - Knop is disabled + waarschuwing wanneer er nog geen assessments zijn — bevinding hangt altijd aan een assessment (audit-trail-conventie) - Assessment-dropdown toont "type · domein · datum" zodat reviewers snel het juiste assessment kiezen api-client - `api.findings.create(data)` + `api.findings.update(id, data)` toegevoegd Tests - 4 nieuwe vitest-tests in `bevindingen/page.test.tsx`: empty-state, validatie verplichte velden, create-flow met API-spy, ernst-filter werkt - 2 e2e-tests in `beheer-bevindingen-create.spec.ts`: UI → API → DB verificatie via psql; validatie zonder verplichte velden Lokaal: 55/55 vitest pass (was 51), typecheck clean, 0 lint-errors. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wat
Tijdens validatie voor de demo van 28 mei bleek dat /beheer/bevindingen lees-only was — geen create-knop in de UI, terwijl backend (
POST /assessments/findings/) al wel werkt. Voor de audit-/QA-rol-stakeholder (Hans Hoekstra) is dit een wezenlijke flow. Deze PR sluit de gap.Wijzigingen
Tests
Lokaal: 55/55 vitest pass, typecheck clean, 0 lint-errors.
Test plan