Conversation
0d15650 to
924a70b
Compare
051e889 to
94c9e65
Compare
d16d18e to
287eb7d
Compare
4b586d1 to
dd76eaa
Compare
|
@panch1739 Take another look please |
dd76eaa to
48ab2bb
Compare
48ab2bb to
a1229b3
Compare
|
Documentation. Coverage Reports: |
55d5f74 to
d7e3c76
Compare
|
First PR for base components #877 |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 96 out of 96 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
projects/element-ng/chat-messages/si-markdown-content.component.ts:1
- The first
.replace('.', '.')does nothing because it's replacing a literal dot with a literal dot. This should likely be.replace(/\./g, '\\.')to properly escape dots for regex.
/**
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
projects/element-ng/chat-messages/si-chat-container.component.ts
Outdated
Show resolved
Hide resolved
|
This (which is now basically just the chat-container) is also now ready for review IMO, it works both in a declarative and model-driven way, with a nice signal-based API for streaming and auto-scroll, which I dogfooded in the Agent. |
|
Moved the tool message to #967 |
|
@spike-rabbit Split it into a base generic component (which doesn't even need to be AI specific now) and a mostly model-driven wrapper. Sketched the new Architecture (ignore the tool message, not a part of this) |
|
Did some improvements and changed it to use the same entrypoint after discussing with @kfenner , will split into two PRs |
|
@kfenner @spike-rabbit Refactored out the model-API wrapper to #998 , ready to review |
|
🎉 This PR is included in version 48.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |

This adds the chat-container (fully declarative with auto-scroll), potential follow-ups are an ai-chat-container wrapper (model based with a nice signal-based API for streaming / loading state), dogfooded) in #998 (tool message is here #967 )
The chat input is in #948 (merged), the base components (merged) in #877, the file upload directive (merged) in #932
Rough Architecture (ignore the ai chat container for now and the tool message, not a part of this)
