Skip to content

feat: add chat container#600

Merged
kfenner merged 5 commits intomainfrom
feat/add-chat-components-in-chat-messages
Nov 12, 2025
Merged

feat: add chat container#600
kfenner merged 5 commits intomainfrom
feat/add-chat-components-in-chat-messages

Conversation

@Killusions
Copy link
Copy Markdown
Member

@Killusions Killusions commented Aug 19, 2025

This adds the chat-container (fully declarative with auto-scroll), potential follow-ups are an ai-chat-container wrapper (model based with a nice signal-based API for streaming / loading state), dogfooded) in #998 (tool message is here #967 )

The chat input is in #948 (merged), the base components (merged) in #877, the file upload directive (merged) in #932

Rough Architecture (ignore the ai chat container for now and the tool message, not a part of this)
ai-chat-container


@Killusions Killusions force-pushed the feat/add-chat-components-in-chat-messages branch 4 times, most recently from 0d15650 to 924a70b Compare August 20, 2025 16:25
@Killusions Killusions force-pushed the feat/add-chat-components-in-chat-messages branch 2 times, most recently from 051e889 to 94c9e65 Compare September 1, 2025 12:46
@Killusions Killusions force-pushed the feat/add-chat-components-in-chat-messages branch 24 times, most recently from d16d18e to 287eb7d Compare September 22, 2025 14:34

This comment was marked as outdated.

@Killusions Killusions force-pushed the feat/add-chat-components-in-chat-messages branch from 4b586d1 to dd76eaa Compare October 13, 2025 11:12
@Killusions
Copy link
Copy Markdown
Member Author

@panch1739 Take another look please

@Killusions Killusions force-pushed the feat/add-chat-components-in-chat-messages branch from dd76eaa to 48ab2bb Compare October 13, 2025 11:26
@siemens siemens deleted a comment from github-actions bot Oct 13, 2025
@Killusions Killusions force-pushed the feat/add-chat-components-in-chat-messages branch from 48ab2bb to a1229b3 Compare October 13, 2025 11:49
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 13, 2025

@Killusions Killusions force-pushed the feat/add-chat-components-in-chat-messages branch 4 times, most recently from 55d5f74 to d7e3c76 Compare October 13, 2025 15:56
@Killusions
Copy link
Copy Markdown
Member Author

First PR for base components #877

@Killusions Killusions mentioned this pull request Oct 16, 2025
1 task
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 96 out of 96 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

projects/element-ng/chat-messages/si-markdown-content.component.ts:1

  • The first .replace('.', '.') does nothing because it's replacing a literal dot with a literal dot. This should likely be .replace(/\./g, '\\.') to properly escape dots for regex.
/**

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Killusions Killusions mentioned this pull request Nov 1, 2025
1 task
@Killusions
Copy link
Copy Markdown
Member Author

This (which is now basically just the chat-container) is also now ready for review IMO, it works both in a declarative and model-driven way, with a nice signal-based API for streaming and auto-scroll, which I dogfooded in the Agent.

@Killusions
Copy link
Copy Markdown
Member Author

Killusions commented Nov 5, 2025

Moved the tool message to #967

@Killusions
Copy link
Copy Markdown
Member Author

@spike-rabbit Split it into a base generic component (which doesn't even need to be AI specific now) and a mostly model-driven wrapper.

Sketched the new Architecture (ignore the tool message, not a part of this)
ai-chat-container

@Killusions
Copy link
Copy Markdown
Member Author

Did some improvements and changed it to use the same entrypoint after discussing with @kfenner , will split into two PRs

@Killusions Killusions mentioned this pull request Nov 10, 2025
1 task
@Killusions
Copy link
Copy Markdown
Member Author

@kfenner @spike-rabbit Refactored out the model-API wrapper to #998 , ready to review

@github-actions
Copy link
Copy Markdown

Code Coverage

Copy link
Copy Markdown
Member

@kfenner kfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Killusions Love it 💜

LGTM 👍

@siemens-element-bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants