Skip to content

feat: add base chat messages#877

Merged
kfenner merged 3 commits intomainfrom
feat/add-base-chat-message
Nov 4, 2025
Merged

feat: add base chat messages#877
kfenner merged 3 commits intomainfrom
feat/add-base-chat-message

Conversation

@Killusions
Copy link
Copy Markdown
Member

@Killusions Killusions commented Oct 16, 2025

Adds base chat-messages (holds content, actions and attachments), in preparation for next step (chat-container and input)

Consists of one generic chat-message (declarative) and two factories (ai and user message), as well as the attachment list.

The user-message and ai-message components are the building blocks for the chat-container.

Uses #915 (merged)


Copilot AI review requested due to automatic review settings October 16, 2025 01:04
@Killusions Killusions requested a review from a team as a code owner October 16, 2025 01:04
@Killusions Killusions requested a review from kfenner October 16, 2025 01:04
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the foundational chat message components for building chat interfaces. The implementation includes specialized message components (user and AI), along with supporting utilities for markdown rendering, attachments, and actions.

Key changes:

  • Implements comprehensive chat message system with user and AI message variants
  • Adds markdown content renderer with security features and proper formatting
  • Provides attachment display and management functionality with file type icons

Reviewed Changes

Copilot reviewed 62 out of 63 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
projects/element-ng/chat-messages/ Core chat message components implementation with TypeScript, tests, and styling
src/app/examples/ Example components demonstrating chat message usage patterns
docs/components/chat-messages/ Documentation updates with component examples and API references
projects/element-ng/translate/ Translation key additions for new chat message labels
projects/element-theme/src/styles/ Theme token addition for experimental input styling
playwright/ Visual regression tests and snapshots for component verification

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Killusions Killusions force-pushed the feat/add-base-chat-message branch 3 times, most recently from 4630418 to 9113855 Compare October 16, 2025 11:05
@github-actions
Copy link
Copy Markdown

@Killusions Killusions force-pushed the feat/add-base-chat-message branch 4 times, most recently from 91917c4 to b08bc1c Compare October 16, 2025 15:35
@Killusions
Copy link
Copy Markdown
Member Author

Added support for Markdown tables

@Killusions Killusions force-pushed the feat/add-base-chat-message branch 4 times, most recently from 29e8705 to 4e1f73b Compare October 16, 2025 22:54
@Killusions
Copy link
Copy Markdown
Member Author

Killusions commented Oct 16, 2025

This should be ready now, I marked the base components (attachments, markdown, ...) as experimental, as we might remove or rename them or change their API.

@Killusions Killusions mentioned this pull request Oct 16, 2025
1 task
@Killusions
Copy link
Copy Markdown
Member Author

@timowolf @spike-rabbit This is also fine for UX, please have a look if you have time, then after this we can do the input and the container with #600

Copy link
Copy Markdown
Member

@spike-rabbit spike-rabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some more details in the PR description.

Why do we need ai and user messages? Do they add any real value compared to the chat-message?

@Killusions Killusions force-pushed the feat/add-base-chat-message branch 2 times, most recently from bc5b147 to 648a6da Compare October 17, 2025 09:00
@Killusions
Copy link
Copy Markdown
Member Author

The user-message and ai-message components are the building blocks for the chat-container, they can be used by the user using templates and ng-content, and are used internally by us.

Adjusted the description:

The user-message and ai-message components are the building blocks for the chat-container, they can be used by the user using templates and ng-content, and are also used internally by us.

@Killusions Killusions force-pushed the feat/add-base-chat-message branch from 648a6da to 3812cbd Compare October 17, 2025 09:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 61 out of 61 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Killusions Killusions force-pushed the feat/add-base-chat-message branch from 3812cbd to 7fdb5e9 Compare October 21, 2025 12:21
@Killusions Killusions force-pushed the feat/add-base-chat-message branch 5 times, most recently from 426a344 to 2a88588 Compare October 30, 2025 16:24
Copy link
Copy Markdown
Member

@timowolf timowolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, some remarks here. The docs can also be changed later, but I would ask to change and remove the id of the actions and attachments if possible. I do not see any use at the moment.

@Killusions Killusions force-pushed the feat/add-base-chat-message branch from 2a88588 to 38b0e3c Compare October 31, 2025 17:22
@Killusions
Copy link
Copy Markdown
Member Author

@timowolf Thank you, back to you

@Killusions Killusions force-pushed the feat/add-base-chat-message branch 2 times, most recently from c24ad8d to 360ed5a Compare October 31, 2025 20:38
@Killusions
Copy link
Copy Markdown
Member Author

axe detected an issue with the interactivity of the attachment list, fixed.

@Killusions Killusions force-pushed the feat/add-base-chat-message branch from 360ed5a to 265a840 Compare October 31, 2025 22:18
@Killusions Killusions mentioned this pull request Nov 1, 2025
1 task
Copy link
Copy Markdown
Member

@timowolf timowolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@Killusions Killusions force-pushed the feat/add-base-chat-message branch 4 times, most recently from 44b9444 to 07e8f56 Compare November 4, 2025 14:37
Copy link
Copy Markdown
Member

@kfenner kfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kfenner kfenner dismissed stale reviews from spike-rabbit and timowolf November 4, 2025 15:47

addressed

@kfenner kfenner enabled auto-merge (rebase) November 4, 2025 15:47
@kfenner kfenner force-pushed the feat/add-base-chat-message branch from 07e8f56 to e5529b6 Compare November 4, 2025 15:47
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 4, 2025

Code Coverage

@kfenner kfenner merged commit 64f39af into main Nov 4, 2025
10 checks passed
@siemens-element-bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants