Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds the foundational chat message components for building chat interfaces. The implementation includes specialized message components (user and AI), along with supporting utilities for markdown rendering, attachments, and actions.
Key changes:
- Implements comprehensive chat message system with user and AI message variants
- Adds markdown content renderer with security features and proper formatting
- Provides attachment display and management functionality with file type icons
Reviewed Changes
Copilot reviewed 62 out of 63 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
projects/element-ng/chat-messages/ |
Core chat message components implementation with TypeScript, tests, and styling |
src/app/examples/ |
Example components demonstrating chat message usage patterns |
docs/components/chat-messages/ |
Documentation updates with component examples and API references |
projects/element-ng/translate/ |
Translation key additions for new chat message labels |
projects/element-theme/src/styles/ |
Theme token addition for experimental input styling |
playwright/ |
Visual regression tests and snapshots for component verification |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
projects/element-ng/chat-messages/si-chat-message.component.scss
Outdated
Show resolved
Hide resolved
4630418 to
9113855
Compare
|
Documentation. Coverage Reports: |
91917c4 to
b08bc1c
Compare
|
Added support for Markdown tables |
29e8705 to
4e1f73b
Compare
|
This should be ready now, I marked the base components (attachments, markdown, ...) as experimental, as we might remove or rename them or change their API. |
|
@timowolf @spike-rabbit This is also fine for UX, please have a look if you have time, then after this we can do the input and the container with #600 |
spike-rabbit
left a comment
There was a problem hiding this comment.
Please add some more details in the PR description.
Why do we need ai and user messages? Do they add any real value compared to the chat-message?
projects/element-ng/markdown-renderer/si-markdown-content.component.ts
Outdated
Show resolved
Hide resolved
projects/element-ng/chat-messages/si-markdown-content.component.html
Outdated
Show resolved
Hide resolved
bc5b147 to
648a6da
Compare
Adjusted the description: The user-message and ai-message components are the building blocks for the chat-container, they can be used by the user using templates and ng-content, and are also used internally by us. |
648a6da to
3812cbd
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 61 out of 61 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
3812cbd to
7fdb5e9
Compare
projects/element-ng/chat-messages/si-attachment-list.component.html
Outdated
Show resolved
Hide resolved
426a344 to
2a88588
Compare
timowolf
left a comment
There was a problem hiding this comment.
Many thanks, some remarks here. The docs can also be changed later, but I would ask to change and remove the id of the actions and attachments if possible. I do not see any use at the moment.
projects/element-ng/chat-messages/si-attachment-list.component.ts
Outdated
Show resolved
Hide resolved
2a88588 to
38b0e3c
Compare
|
@timowolf Thank you, back to you |
c24ad8d to
360ed5a
Compare
|
axe detected an issue with the interactivity of the attachment list, fixed. |
360ed5a to
265a840
Compare
projects/element-ng/chat-messages/si-attachment-list.component.ts
Outdated
Show resolved
Hide resolved
44b9444 to
07e8f56
Compare
07e8f56 to
e5529b6
Compare
|
🎉 This PR is included in version 48.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Adds base chat-messages (holds content, actions and attachments), in preparation for next step (chat-container and input)
Consists of one generic chat-message (declarative) and two factories (ai and user message), as well as the attachment list.
The user-message and ai-message components are the building blocks for the chat-container.
Uses #915 (merged)