chore: Prepare platform-routed CSS transitions for more properties#9654
Open
MatiPl01 wants to merge 1 commit into
Open
chore: Prepare platform-routed CSS transitions for more properties#9654MatiPl01 wants to merge 1 commit into
MatiPl01 wants to merge 1 commit into
Conversation
d5ab0f4 to
3b6d0b2
Compare
abbb119 to
ca5cb7d
Compare
ca5cb7d to
7a8e5e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #9552.
Prepares the platform transition machinery for routing more properties to Core Animation, with a clean platform boundary:
PlatformValueis an abstract, platform-defined type: shared C++ only declares it (utils/platform.h); iOS defines its concrete shapes inREACSSPlatformValue.h(scalars, sizes, RGBA colors)parsePlatformValueis declared in shared code and implemented by the platform (iOS inREACSSValueConversion.mm); values are parsed once at routing time and routed entries carry the parsed values to the apply callback - no re-parsing anywhereREACSSTransitionRouting(routing predicate, owns theIOS_CSS_CORE_ANIMATIONgate moved out of shared C++),REACSSValueConversion(parsing, CSS defaults, conversions, timing functions),REACSSPlatformTransitions(apply/remove only)No behavior change: the routable property set is still opacity-only.
Test plan
-fsyntax-onlycompile check on all touched translation units