Skip to content

chore: Prepare platform-routed CSS transitions for more properties#9654

Open
MatiPl01 wants to merge 1 commit into
@matipl01/css-transitions-cleanupfrom
@matipl01/css-platform-transition-values
Open

chore: Prepare platform-routed CSS transitions for more properties#9654
MatiPl01 wants to merge 1 commit into
@matipl01/css-transitions-cleanupfrom
@matipl01/css-platform-transition-values

Conversation

@MatiPl01

@MatiPl01 MatiPl01 commented Jun 11, 2026

Copy link
Copy Markdown
Member

Summary

Stacked on #9552.

Prepares the platform transition machinery for routing more properties to Core Animation, with a clean platform boundary:

  • PlatformValue is an abstract, platform-defined type: shared C++ only declares it (utils/platform.h); iOS defines its concrete shapes in REACSSPlatformValue.h (scalars, sizes, RGBA colors)
  • parsePlatformValue is declared in shared code and implemented by the platform (iOS in REACSSValueConversion.mm); values are parsed once at routing time and routed entries carry the parsed values to the apply callback - no re-parsing anywhere
  • a failed parse routes the property to the loop, including pseudo-toggle diffs (previously such values could reach the renderer and throw)
  • iOS platform code split: REACSSTransitionRouting (routing predicate, owns the IOS_CSS_CORE_ANIMATION gate moved out of shared C++), REACSSValueConversion (parsing, CSS defaults, conversions, timing functions), REACSSPlatformTransitions (apply/remove only)

No behavior change: the routable property set is still opacity-only.

Test plan

  • -fsyntax-only compile check on all touched translation units
  • clang-format clean

@MatiPl01 MatiPl01 self-assigned this Jun 11, 2026
@MatiPl01 MatiPl01 force-pushed the @matipl01/css-platform-transition-values branch from d5ab0f4 to 3b6d0b2 Compare June 12, 2026 00:00
@MatiPl01 MatiPl01 changed the base branch from main to @matipl01/css-transitions-cleanup June 12, 2026 00:00
@MatiPl01 MatiPl01 force-pushed the @matipl01/css-platform-transition-values branch 4 times, most recently from abbb119 to ca5cb7d Compare June 12, 2026 09:38
@MatiPl01 MatiPl01 force-pushed the @matipl01/css-platform-transition-values branch from ca5cb7d to 7a8e5e6 Compare June 12, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant