chore: Make platform transition routing aware of committed view props#9655
Open
MatiPl01 wants to merge 1 commit into
Open
Conversation
MatiPl01
force-pushed
the
@matipl01/css-platform-transition-values
branch
from
d5ab0f4 to
3b6d0b2
Compare
MatiPl01
force-pushed
the
@matipl01/css-platform-routing-eligibility
branch
2 times, most recently
from
fc9dfc8 to
47a4295
Compare
MatiPl01
force-pushed
the
@matipl01/css-platform-transition-values
branch
5 times, most recently
from
ca5cb7d to
7a8e5e6
Compare
MatiPl01
force-pushed
the
@matipl01/css-platform-routing-eligibility
branch
from
47a4295 to
7964685
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #9654.
The
canRouteplatform hook now receives the view's latest committedShadowNode(resolved viaViewStylesRepository::getNewestShadowNodeonce per routing pass) and the set of co-transitioning property names, so platform implementations can reject properties whose rendering depends on sibling style.No behavior change yet: the routable set is still opacity-only; prop-specific eligibility conditions land together with the properties that need them.
Test plan
-fsyntax-onlycompile check on all touched translation units