Fix SSL last run ID type#46
Open
jcsco wants to merge 1 commit into
Open
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to splunk/terraform-provider-synthetics#94
Before the change?
SslCheckV2Response.Test.LastRunIdwas modeled as anint.lastRunIdas a UUID string, so decoding an SSL check response could fail withcannot unmarshal string into Go struct field ...lastRunId of type int.After the change?
lastRunIdvalues as strings.lastRunIdthroughGetSslCheckV2and assert that the response preserves it exactly.Pull request checklist
Test Output
Additional validation:
Does this introduce a breaking change?
This changes the type of the exported
LastRunIdfield frominttostring. Code that assigns or compares an integer directly will need to use the API's UUID string representation instead.