drivers: add unknown_model#3
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28d161afe8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,30 @@ | |||
| -- Hugin workbench draft — fill this in with AI's help. | |||
| DRIVER = { | |||
| id = "unknown_model", | |||
There was a problem hiding this comment.
This commit adds a new DRIVER.id (unknown_model) but does not update manifest.json, so CI will fail in the verify workflow (.github/workflows/verify.yml runs go run ./cmd/driverrepo -verify). In cmd/driverrepo/main.go, verifyManifest compares the checked-in manifest to the driver set and returns manifest.json is out of date when a new driver file exists without regeneration.
Useful? React with 👍 / 👎.
| @@ -0,0 +1,30 @@ | |||
| -- Hugin workbench draft — fill this in with AI's help. | |||
There was a problem hiding this comment.
The new file omits the required sign-convention note, which causes repository verification to fail: verifyDrivers calls documentsSignConvention and rejects drivers missing phrases like sign convention/positive = import (cmd/driverrepo/main.go). Since .github/workflows/verify.yml enforces this check on every push/PR, this driver cannot pass CI as written.
Useful? React with 👍 / 👎.
|
Thanks for the PR! This looks like an empty placeholder template from the workbench — verification_status is 'experimental' with no tested_models and the four function bodies are TODO stubs. Closing in favor of completed drivers; happy to re-open if you fill in a real device's register map. We'll also be landing a 'hugin-drivers init' template generator soon to make this contribution path smoother — track that in #5 (coming). |
1 participant
Drafted via Hugin workbench (https://hugin.sourceful-labs.net/workbench.html).
Submitted via Hugin by @frahlg.