Skip to content

drivers: add unknown_model #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frahlg wants to merge 1 commit into from
Closed

drivers: add unknown_model #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions drivers/unknown_model.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
-- Hugin workbench draft — fill this in with AI's help.

@chatgpt-codex-connector chatgpt-codex-connector Bot May 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Document site sign convention in the new driver

The new file omits the required sign-convention note, which causes repository verification to fail: verifyDrivers calls documentsSignConvention and rejects drivers missing phrases like sign convention/positive = import (cmd/driverrepo/main.go). Since .github/workflows/verify.yml enforces this check on every push/PR, this driver cannot pass CI as written.

Useful? React with 👍 / 👎.

DRIVER = {
id = "unknown_model",

@chatgpt-codex-connector chatgpt-codex-connector Bot May 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Regenerate manifest after introducing this driver

This commit adds a new DRIVER.id (unknown_model) but does not update manifest.json, so CI will fail in the verify workflow (.github/workflows/verify.yml runs go run ./cmd/driverrepo -verify). In cmd/driverrepo/main.go, verifyManifest compares the checked-in manifest to the driver set and returns manifest.json is out of date when a new driver file exists without regeneration.

Useful? React with 👍 / 👎.

name = "Unknown Model",
manufacturer = "Unknown",
version = "0.1.0",
protocols = { "modbus" },
capabilities = { "meter" },
tested_models = {},
verification_status = "experimental",
verification_notes = "Drafted via Hugin workbench; not yet verified on live hardware.",
description = "TODO: one-sentence purpose.",
connection_defaults = { port = 502, slave_id = 1 },
}

PROTOCOL = "modbus"

function driver_init(config)
host.set_make("Unknown")
host.set_sn(config.serial or "unknown")
end

function driver_poll()
-- TODO: read registers, host.emit("meter", {...})
return 5000
end

function driver_command(action, power_w, cmd) end
function driver_default_mode() end
function driver_cleanup() end
Loading