fix: SW-2054 correct DataAppShell Storybook E2E test assertions for icon-only rail

[Copilot]

Three play-test assertions in DataAppShell.stories.tsx were not updated to match the component changes landed in PR #138 (icon-only nav rail, removed count display, narrowed rail width), causing the Storybook E2E job to fail.

Summary

Root cause: PR #138 changed the DataAppShell component but left three stale test assertions:

Story	Stale assertion	Fix
Workflow Panel Interactions	getByText("1K") — count pills removed from WorkflowPanel	Remove the assertion; rename step to "shows step labels"
Multiple Nav Groups	getByText("Filters") within the icon rail — labels moved to aria-label	getByRole("button", { name: "Filters" })
Compact Property	railStyles.width === "60px" — rail narrowed from w-[60px] to w-12	Assert "48px"

Also carries the component changes from PR #138 (DataAppShell.tsx: icon-only compact buttons with aria-label, w-12 rail, 30px icon box, removed label span).

Type of Change

• Feature (new functionality)
• Bug fix
• Refactor
• Documentation
• Chore (build, CI, dependencies)
• Breaking change

Checklist

• yarn lint passes
• yarn build passes
• yarn test:all passes
• Storybook stories added/updated
• Code coverage remains the same or increased

Testing

SW-T4672 (Workflow Panel Interactions), SW-T4673 (Multiple Nav Groups), SW-T4677 (Compact Property)

Verification

• Deploys to preview environment for manual verification
• All CI/E2E checks pass

Screenshots

N/A — test-only corrections; no visual change beyond what PR #138 already introduced.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
ts-lib-ui-kit-storybook	Ready	Preview, Comment	Jul 2, 2026 4:51pm

[Copilot]

Pull request overview

Fixes Storybook play-test failures introduced by the DataAppShell nav rail/workflow demo UI updates (icon-only rail, removed count display, narrower rail), and carries the corresponding component/story adjustments into this branch so the assertions match the rendered output.

Changes:

• Updated DataAppShell to support an icon-only desktop nav rail (ARIA labels + tooltip) with a narrower width and adjusted sizing/typography.
• Updated DataAppShell stories/play functions to assert against accessible names (getByRole(..., { name })) and the new rail width, and removed stale count assertions.
• Added navRailHidden to allow hiding the desktop nav rail (used by the collapsed workflow story).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/components/composed/DataAppShell/DataAppShell.tsx	Implements the icon-only, narrower desktop nav rail behavior and adds navRailHidden for conditional rail rendering.
src/components/composed/DataAppShell/DataAppShell.stories.tsx	Updates demo content and play-test assertions to match the updated rail/workflow UI and accessibility approach.

Comments suppressed due to low confidence (1)

src/components/composed/DataAppShell/DataAppShell.stories.tsx:359

• Similarly, the Next button should use the derived steps array (the source of truth for active state) rather than indexing into htsWorkflowSteps. This reduces the chance of navigation bugs if the rendered steps change independently of the original constant.

          <Button
            size="sm"
            disabled={isLastStep}
            onClick={() => !isLastStep && setActiveStepId(htsWorkflowSteps[activeStepIndex + 1].id)}
            className="gap-1"

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[54321jenn-ts]

LGTM

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🟢	Lines	94.84% (🎯 83%) ⬆️ +0.01%	20955 / 22095
🟢	Statements	94.84% (🎯 83%) ⬆️ +0.01%	20955 / 22095
🟢	Functions	93.59% (🎯 74%) 🟰 ±0%	920 / 983
🟢	Branches	89.39% (🎯 81%) ⬆️ +0.04%	3930 / 4396

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
src/components/composed/DataAppShell/DataAppShell.tsx	97.92% 🟰 ±0%	88.13% 🟰 ±0%	85.71% 🟰 ±0%	97.92% 🟰 ±0%	213-214, 302-307

Generated in workflow #903 for commit 6e05022 by the Vitest Coverage Report Action