Skip to content

fix: SW-2054 correct DataAppShell Storybook E2E test assertions for icon-only rail #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owilliams-tetrascience merged 5 commits into from
Jul 2, 2026
Merged

fix: SW-2054 correct DataAppShell Storybook E2E test assertions for icon-only rail #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c1c6faf
Initial plan
Copilot Jun 24, 2026
e45169b
fix: update DataAppShell E2E tests to match icon-only rail and remove…
Copilot Jun 24, 2026
6d8e832
Merge branch 'main' into copilot/fix-storybook-e2e-tests-again
owilliams-tetrascience Jul 2, 2026
8cb37e3
Potential fix for pull request finding
owilliams-tetrascience Jul 2, 2026
6e05022
refactor: remove unused inputCount/outputCount from WorkflowStep
Copilot Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/components/composed/DataAppShell/DataAppShell.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,6 @@ interface WorkflowStep {
isActive?: boolean;
disabled?: boolean;
disabledReason?: string;
inputCount?: number;
outputCount?: number;
onClick?: () => void;
}

Expand Down Expand Up @@ -346,7 +344,7 @@ const DefaultShell = ({ initialCollapsed = false }: { initialCollapsed?: boolean
<Button
variant="outline"
size="sm"
onClick={() => setActiveStepId(htsWorkflowSteps[activeStepIndex - 1].id)}
onClick={() => setActiveStepId(steps[activeStepIndex - 1].id)}
className="gap-1"
>
Back
Expand Down Expand Up @@ -715,17 +713,13 @@ const WorkflowInteractionShell = () => {
icon: LayoutGrid,
isActive: activeStepId === "step-a",
onClick: () => setActiveStepId("step-a"),
inputCount: 1000,
outputCount: 800,
},
{
id: "step-b",
label: "Step Beta",
icon: Filter,
isActive: activeStepId === "step-b",
onClick: () => setActiveStepId("step-b"),
inputCount: 800,
outputCount: 200,
},
{ id: "step-c", label: "Disabled", icon: Search, disabled: true, disabledReason: "Requires upstream data" },
];
Expand Down
2 changes: 0 additions & 2 deletions src/components/composed/DataAppShell/DataAppShell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,6 @@ function SidebarBody({
<div
className={cn(
"shrink-0 flex",
// Expanded: full-width header border. Collapsed: no full-width border —
// a short centered divider (below) aligns under the icon column instead.
compact ? "justify-center pt-1 pb-2" : "px-3 py-2.5 border-b border-sidebar-border"
)}
>
Expand Down
Loading