perf(ptv3): simplify SerializedPooling export clustering#206
Draft
mojomex wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes the PTv3
SerializedPoolingexport path to derive pooling clusters directly from the existing serialized order instead of using the export-onlyuniquepath.It also adds a focused module test that checks export mode against train mode for
SerializedPooling.What changed
uniqueinSerializedPoolingcluster,indices, andidx_ptrby scanning pooled-code boundaries along the existing serialized orderprojects/PTv3/tests/test_serialized_pooling.pyto verify export-mode and train-time outputs match for the changed moduleValidation
pytest -q projects/PTv3/tests/test_serialized_pooling.pyBenchmark context
This exact SerializedPooling change was benchmarked separately on an inference box. That rerun measured GPU total replicate-mean latency at
24.868 msversus the original26.937 msbaseline, a2.069 ms(7.68%) improvement.The benchmark/profile artifacts are intentionally not part of this PR.