WIP: wifi: mt76: mt7902: correct regs.h#11
Open
hmtheboy154 wants to merge 1 commit into
Open
Conversation
Info based on Xiaomi's "rodin" BSP https://github.com/MiCode/MTK_kernel_modules/blob/bsp-rodin-v-oss/connectivity/wlan/core/gen4-mt79xx/chips/mt7902/mt7902.c#L237 https://github.com/MiCode/MTK_kernel_modules/blob/bsp-rodin-v-oss/connectivity/wlan/core/gen4-mt79xx/chips/mt7902/mt7902.c#L373 This is considered as WIP because: - Untested - I don't know how to calculate these HOST_TX_DONE_INT_ENA* bits or knowing which one is needed. Signed-off-by: hmtheboy154 <buingoc67@gmail.com>
Open
|
bonus on the RX stuff: mt7902 uses only one queue for rx event and tx free event, so that must be handled too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Info based on Xiaomi's "rodin" BSP
https://github.com/MiCode/MTK_kernel_modules/blob/bsp-rodin-v-oss/connectivity/wlan/core/gen4-mt79xx/chips/mt7902/mt7902.c#L237
https://github.com/MiCode/MTK_kernel_modules/blob/bsp-rodin-v-oss/connectivity/wlan/core/gen4-mt79xx/chips/mt7902/mt7902.c#L373
This is considered as WIP because:
I still keep MT_INT_TX_DONE_MCU_WM to HOST_TX_DONE_INT_ENA17 due to this comment in the BSP driver. I don't know if doing this is correct.https://github.com/MiCode/MTK_kernel_modules/blob/bsp-rodin-v-oss/connectivity/wlan/core/gen4-mt79xx/chips/mt7902/mt7902.c#L310
Update: for 3 I think I got a clue, I saw that the driver in the BSP also has driver for
mt7925here. From their driver I can see that it basically use ring 15 for TX CMD, and ring 17 to enable setting.https://github.com/MiCode/MTK_kernel_modules/blob/bsp-rodin-v-oss/connectivity/wlan/core/gen4m/chips/mt7925/mt7925.c#L1334
mt7902uses ring 15 for TX CMD too, but 17 is being used as "interrupt CR field" so I think setMT_INT_TX_DONE_MCU_WMlikemt7925should be ok.